)]}'
{
  "commit": "d63ebabd63142a3865c0801292a441ee8c38e03b",
  "tree": "0fb79e5d77d0ba474c4be5ff168ff5142a4feca7",
  "parents": [
    "1e926e4233a7e88039950e5b3212b19d5a63ff5a"
  ],
  "author": {
    "name": "Viet-Trung Luu",
    "email": "viettrungluu@chromium.org",
    "time": "Tue May 17 15:49:50 2016 -0700"
  },
  "committer": {
    "name": "Viet-Trung Luu",
    "email": "viettrungluu@chromium.org",
    "time": "Tue May 17 15:49:50 2016 -0700"
  },
  "message": "Make ApplicationTestBase not use ApplicationImpl.\n\nIt didn\u0027t have much reason to.\n\nThis allows us to make ApplicationImpl\u0027s Application implementation\nprivate.\n\nMy plan:\n* Factor out the guts of ApplicationImpl to a new class called\n  ApplicationImplBase, which would have a bunch of (possibly pure)\n  virtual methods meant to be overridden. (I\u0027d mark methods not meant to\n  be overridden as |final|.)\n* ApplicationImpl would (temporarily?) remain, implementing these\n  methods by calling out to ApplicationDelegate.\n* Convert code to just subclassing/implementing ApplicationImplBase,\n  instead of ApplicationDelegate (and instantiating that class, instead\n  of ApplicationImpl + their delegate).\n* Once no one uses ApplicationImpl/ApplicationDelegate anymore, we can\n  remove them.\n\nR\u003dvardhan@google.com\n\nReview URL: https://codereview.chromium.org/1990603002 .\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "2de4515c7cfd5816c43b2a4d1722c225d9bd1ec2",
      "old_mode": 33188,
      "old_path": "examples/apptest/example_apptest.cc",
      "new_id": "30847b92a06b9772ac3ffd2e6b58a6adaf2748fe",
      "new_mode": 33188,
      "new_path": "examples/apptest/example_apptest.cc"
    },
    {
      "type": "modify",
      "old_id": "d3f6cfc35cad4b8d704cb72e32b81c9c99cc3d84",
      "old_mode": 33188,
      "old_path": "mojo/file_utils/file_util_unittest.cc",
      "new_id": "89afc456260cabbc238a928b5eff5c439a5c97b8",
      "new_mode": 33188,
      "new_path": "mojo/file_utils/file_util_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "68dc5657565f167d91fd42f8eda73087cd0cd470",
      "old_mode": 33188,
      "old_path": "mojo/public/cpp/application/application_impl.h",
      "new_id": "2621daa1bb2a0a5cd017cb0359ebd139a6b7091c",
      "new_mode": 33188,
      "new_path": "mojo/public/cpp/application/application_impl.h"
    },
    {
      "type": "modify",
      "old_id": "eb98b85c2b5df910c63dd77d8b3cb157d1724da0",
      "old_mode": 33188,
      "old_path": "mojo/public/cpp/application/application_test_base.h",
      "new_id": "a81119e963d5523bb3a2ad7bf68864d2e034c8d2",
      "new_mode": 33188,
      "new_path": "mojo/public/cpp/application/application_test_base.h"
    },
    {
      "type": "modify",
      "old_id": "42ebb8ce9751b1ffe6f692461744178e146bac68",
      "old_mode": 33188,
      "old_path": "mojo/public/cpp/application/lib/application_impl.cc",
      "new_id": "6be42ff0b239afce6a16ac8d0bd6575737965ee0",
      "new_mode": 33188,
      "new_path": "mojo/public/cpp/application/lib/application_impl.cc"
    },
    {
      "type": "modify",
      "old_id": "f316daab0a446120fb26348a09a6b51a93d12ed7",
      "old_mode": 33188,
      "old_path": "mojo/public/cpp/application/lib/application_test_base.cc",
      "new_id": "26811c46415057c798e94a442a795ca387acfc90",
      "new_mode": 33188,
      "new_path": "mojo/public/cpp/application/lib/application_test_base.cc"
    },
    {
      "type": "modify",
      "old_id": "c0c38b56be9452fac7119c92a3b87ec45e79b204",
      "old_mode": 33188,
      "old_path": "mojo/public/cpp/bindings/tests/versioning_apptest.cc",
      "new_id": "2a74873660b6e12dddd51ea9446adc30ab5a7368",
      "new_mode": 33188,
      "new_path": "mojo/public/cpp/bindings/tests/versioning_apptest.cc"
    },
    {
      "type": "modify",
      "old_id": "96abd9fc1853dfedcbf1a95f69830a5ed03532f6",
      "old_mode": 33188,
      "old_path": "mojo/services/files/c/tests/mojio_impl_test_base.cc",
      "new_id": "3b345ee59433b67605dcd98c22a70f606d16ac34",
      "new_mode": 33188,
      "new_path": "mojo/services/files/c/tests/mojio_impl_test_base.cc"
    },
    {
      "type": "modify",
      "old_id": "03e799ba98b068074b2a7ab16f4d1204d4acd748",
      "old_mode": 33188,
      "old_path": "mojo/ui/gl_renderer_apptest.cc",
      "new_id": "863b22f04829aa28f898e36edf1cb6ce8d3391a7",
      "new_mode": 33188,
      "new_path": "mojo/ui/gl_renderer_apptest.cc"
    },
    {
      "type": "modify",
      "old_id": "de2e58b1dd780fee5262317472df36d8b8fb0d3d",
      "old_mode": 33188,
      "old_path": "services/asset_bundle/asset_bundle_apptest.cc",
      "new_id": "4a9cc511cf2461a2380311173da0c9be69afd4fb",
      "new_mode": 33188,
      "new_path": "services/asset_bundle/asset_bundle_apptest.cc"
    },
    {
      "type": "modify",
      "old_id": "b04cc90dccbdaecfb9b7af315146f90cf2d8e677",
      "old_mode": 33188,
      "old_path": "services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_apptest.cc",
      "new_id": "2a3079458fab1969ad77663c516f6efbd16b9772",
      "new_mode": 33188,
      "new_path": "services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_apptest.cc"
    },
    {
      "type": "modify",
      "old_id": "cb483e0123c1ed8a3d3982c4266fb5ec3f3eeb26",
      "old_mode": 33188,
      "old_path": "services/authentication/accounts_db_manager_unittest.cc",
      "new_id": "1d189bc0c6a3a9192462dd3716e0f6905588b0cf",
      "new_mode": 33188,
      "new_path": "services/authentication/accounts_db_manager_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "999f77915b7024271b54a5e1ebf4e288696b203c",
      "old_mode": 33188,
      "old_path": "services/clipboard/clipboard_apptest.cc",
      "new_id": "fbaf59f66c5d2d8db0edb54a51256b915b6af4bc",
      "new_mode": 33188,
      "new_path": "services/clipboard/clipboard_apptest.cc"
    },
    {
      "type": "modify",
      "old_id": "4a3cba2da8de958563044364aa72177776ba8e46",
      "old_mode": 33188,
      "old_path": "services/contacts/contacts_apptest.cc",
      "new_id": "477da471f4ba9f84efb552a959f36eed8635e38a",
      "new_mode": 33188,
      "new_path": "services/contacts/contacts_apptest.cc"
    },
    {
      "type": "modify",
      "old_id": "87ac709756635cf2cb0fb88c7f610053c1499436",
      "old_mode": 33188,
      "old_path": "services/files/files_test_base.cc",
      "new_id": "f4ff3ae63083ae16b08329e95afe3096e7dcf6bd",
      "new_mode": 33188,
      "new_path": "services/files/files_test_base.cc"
    },
    {
      "type": "modify",
      "old_id": "80c37951d96b823715dddd3935ebee5ac8c1516e",
      "old_mode": 33188,
      "old_path": "services/http_server/http_server_apptest.cc",
      "new_id": "f527425822cfcd9bc42de933185376a49a85163b",
      "new_mode": 33188,
      "new_path": "services/http_server/http_server_apptest.cc"
    },
    {
      "type": "modify",
      "old_id": "9d7f3438db1534cf5ddf12728c367755623cb0cc",
      "old_mode": 33188,
      "old_path": "services/js/echo_apptest.cc",
      "new_id": "17ae847fd2d6d2dc80b0373a74992c045f4de6e5",
      "new_mode": 33188,
      "new_path": "services/js/echo_apptest.cc"
    },
    {
      "type": "modify",
      "old_id": "961a70756f15d1c55f06e9f428781c7a5ee7222e",
      "old_mode": 33188,
      "old_path": "services/js/network_apptest.cc",
      "new_id": "d6e0af10f9ba5cf4b584511d2029964608fe32a6",
      "new_mode": 33188,
      "new_path": "services/js/network_apptest.cc"
    },
    {
      "type": "modify",
      "old_id": "f2fe971652d984101ce16a078726e9b5984048f5",
      "old_mode": 33188,
      "old_path": "services/js/pingpong_apptest.cc",
      "new_id": "d76e055ac1217ac5cc24db3f08a1ba2baf7378ef",
      "new_mode": 33188,
      "new_path": "services/js/pingpong_apptest.cc"
    },
    {
      "type": "modify",
      "old_id": "31d8d63fe3f2f185491ec47f546a168ad558a0ed",
      "old_mode": 33188,
      "old_path": "services/native_support/process_test_base.cc",
      "new_id": "c39daed390546bf1cb297b876491ea7f69730d5b",
      "new_mode": 33188,
      "new_path": "services/native_support/process_test_base.cc"
    },
    {
      "type": "modify",
      "old_id": "dc41dd131b112fbd196ee9f60376d9c487934752",
      "old_mode": 33188,
      "old_path": "services/notifications/apptests/notifications_apptest.cc",
      "new_id": "d61fd63e1ea082a68053f44b89f2f04fa3c01712",
      "new_mode": 33188,
      "new_path": "services/notifications/apptests/notifications_apptest.cc"
    },
    {
      "type": "modify",
      "old_id": "8d1b7bcb6d11a2efd787fb5ea83d540271e39049",
      "old_mode": 33188,
      "old_path": "services/prediction/prediction_apptests.cc",
      "new_id": "e739d261298c89ed6072b9d8f3679605cdbe3527",
      "new_mode": 33188,
      "new_path": "services/prediction/prediction_apptests.cc"
    },
    {
      "type": "modify",
      "old_id": "905464c1e34162acfacd6dbff01f52b56050a236",
      "old_mode": 33188,
      "old_path": "services/python/mojo_url_redirector/mojo_url_redirector_apptest.cc",
      "new_id": "5e8e7b753d4f687b41907f6e3e0fa245ed7368f5",
      "new_mode": 33188,
      "new_path": "services/python/mojo_url_redirector/mojo_url_redirector_apptest.cc"
    },
    {
      "type": "modify",
      "old_id": "adf77633a89a38b6b576c0744b793c0129c87be7",
      "old_mode": 33188,
      "old_path": "services/url_response_disk_cache/url_response_disk_cache_apptest.cc",
      "new_id": "05db15957479496848d206298b3e85f7db8033a8",
      "new_mode": 33188,
      "new_path": "services/url_response_disk_cache/url_response_disk_cache_apptest.cc"
    },
    {
      "type": "modify",
      "old_id": "797ae682423e20bb2b7e7c46d73ea81335bcd4eb",
      "old_mode": 33188,
      "old_path": "shell/android/nfc_apptest.cc",
      "new_id": "e4c6420ab91814e7ca2dd68a3a35b7e3d64e01b1",
      "new_mode": 33188,
      "new_path": "shell/android/nfc_apptest.cc"
    },
    {
      "type": "modify",
      "old_id": "42a55478697821b94d24db9672237b681ca84b6a",
      "old_mode": 33188,
      "old_path": "shell/shell_apptest.cc",
      "new_id": "b35db42e64a5ce1d05346c2bc7b84fc331c95257",
      "new_mode": 33188,
      "new_path": "shell/shell_apptest.cc"
    }
  ]
}