commit 22e78b3f728e8b9e937d8222ac47c6b2f161b1f4
author Viet-Trung Luu <viettrungluu@chromium.org> Fri May 13 15:27:15 2016 -0700
committer Viet-Trung Luu <viettrungluu@chromium.org> Fri May 13 15:27:15 2016 -0700
tree c7e8954a0804988ab92d2e7df02d1dba0a2d971e
parent beec2bcc859d393846443860218f842362141f39

ApplicationConnection devolution, part 3.

Make ApplicationDelegate::ConfigureIncomingConnection() take a
ServiceProviderImpl* instead of an ApplicationConnection*.

(Maybe it should also be renamed, but we'll leave that battle for
another day.)

R=vardhan@google.com

Review URL: https://codereview.chromium.org/1979723002 .

shell/application_manager/application_manager_unittest.cc

diff --git a/shell/application_manager/application_manager_unittest.cc b/shell/application_manager/application_manager_unittest.cc
index c8c677e..0337e85 100644
--- a/shell/application_manager/application_manager_unittest.cc
+++ b/shell/application_manager/application_manager_unittest.cc
@@ -121,8 +121,9 @@
   }
 
   // ApplicationDelegate implementation.
-  bool ConfigureIncomingConnection(ApplicationConnection* connection) override {
-    connection->GetServiceProviderImpl().AddService<TestService>(
+  bool ConfigureIncomingConnection(
+      mojo::ServiceProviderImpl* service_provider_impl) override {
+    service_provider_impl->AddService<TestService>(
         [this](const ConnectionContext& connection_context,
                InterfaceRequest<TestService> request) {
           new TestServiceImpl(context_, request.Pass());
@@ -305,9 +306,10 @@
     app_.reset(new ApplicationImpl(this, application_request.Pass()));
   }
 
-  bool ConfigureIncomingConnection(ApplicationConnection* connection) override {
+  bool ConfigureIncomingConnection(
+      mojo::ServiceProviderImpl* service_provider_impl) override {
     const std::string& remote_url =
-        connection->GetServiceProviderImpl().connection_context().remote_url;
+        service_provider_impl->connection_context().remote_url;
     if (!requestor_url_.empty() && requestor_url_ != remote_url) {
       context_->set_tester_called_quit();
       context_->QuitSoon();
@@ -316,13 +318,13 @@
     }
     // If we're coming from A, then add B, otherwise A.
     if (remote_url == kTestAURLString) {
-      connection->GetServiceProviderImpl().AddService<TestB>(
+      service_provider_impl->AddService<TestB>(
           [this](const ConnectionContext& connection_context,
                  InterfaceRequest<TestB> test_b_request) {
             new TestBImpl(context_, test_b_request.Pass());
           });
     } else {
-      connection->GetServiceProviderImpl().AddService<TestA>(
+      service_provider_impl->AddService<TestA>(
           [this](const ConnectionContext& connection_context,
                  InterfaceRequest<TestA> test_a_request) {
             mojo::InterfaceHandle<mojo::ServiceProvider> incoming_sp_handle;
@@ -376,7 +378,8 @@
     base::MessageLoop::current()->Quit();
   }
 
-  bool ConfigureIncomingConnection(ApplicationConnection* connection) override {
+  bool ConfigureIncomingConnection(
+      mojo::ServiceProviderImpl* service_provider_impl) override {
     configure_incoming_connection_called_ = true;
     base::MessageLoop::current()->Quit();
     return true;