)]}'
{
  "commit": "3aefd1bccae360f76b91162edb8de8698e34e98b",
  "tree": "0397a12426d60d75ebd399f437169ef10c4e05da",
  "parents": [
    "b431c268019b5dec77a0e73adcfc090c847b5adb"
  ],
  "author": {
    "name": "James Robinson",
    "email": "jamesr@chromium.org",
    "time": "Tue Feb 10 17:11:46 2015 -0800"
  },
  "committer": {
    "name": "James Robinson",
    "email": "jamesr@chromium.org",
    "time": "Tue Feb 10 17:11:46 2015 -0800"
  },
  "message": "Drop all uses of //base except ObserverList from view mgr client lib\n\nThis removes all uses of //base from the view manager client C++ library\ninterface and implementation except for ObserverList. The tests still\nuse //base fairly extensively to set up message loops and whatnot.  Main\nchanges:\n\n*) use int64_t + \u003cstdint.h\u003e instead of //base/basictypes.h + int64. This\nis what //base/basictypes.h recommends doing anyway *) use lambdas to\nconstruct callbacks instead of base::Bind. We were using\nbase::Unretained() anyway so bind\u0027s lifetime stuff didn\u0027t help us.  *)\nHand-expand the one use of DISALLOW_COPY_AND_ASSIGN *) Remove the one\nused of scoped_ptr in the ViewManagerClientFactory variant used by the\nwindow manager. This one is a bit unfortunate in that it needs a raw\npointer but we should be able to update it to std::unique_ptr\u003c\u003e\nrelatively soon and it\u0027s only used in two places (the window manager\ncommon lib and one test).\n\nThe ObserverList dependency is a bit bigger.\n\nR\u003dsky@chromium.org\n\nReview URL: https://codereview.chromium.org/911073005\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "b1a0bdb2edbebd05ebe3a0d034c42b602c232ee7",
      "old_mode": 33188,
      "old_path": "mojo/services/view_manager/public/cpp/BUILD.gn",
      "new_id": "72cb55e7f6eebcffe3b895f3dd97acff5dd28386",
      "new_mode": 33188,
      "new_path": "mojo/services/view_manager/public/cpp/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "1e8b2b03d298df9218b03b7d5d4be826e1d822b7",
      "old_mode": 33188,
      "old_path": "mojo/services/view_manager/public/cpp/lib/view.cc",
      "new_id": "bfbc67a8cb692ad3c7d81e6f3963d397cca85b0b",
      "new_mode": 33188,
      "new_path": "mojo/services/view_manager/public/cpp/lib/view.cc"
    },
    {
      "type": "modify",
      "old_id": "cfa2b79662c2b1f4210b169765487ab5b6015da6",
      "old_mode": 33188,
      "old_path": "mojo/services/view_manager/public/cpp/lib/view_manager_client_factory.cc",
      "new_id": "bb39fc9d55a95bbeb8f9adb2f46482e8d79afcb0",
      "new_mode": 33188,
      "new_path": "mojo/services/view_manager/public/cpp/lib/view_manager_client_factory.cc"
    },
    {
      "type": "modify",
      "old_id": "574d3001807504c046be29460d1606e2a185c650",
      "old_mode": 33188,
      "old_path": "mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.cc",
      "new_id": "b988903ac3fc814e24cf593dd69028f3590d1fd6",
      "new_mode": 33188,
      "new_path": "mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.cc"
    },
    {
      "type": "modify",
      "old_id": "c3a2ad5ac629d341499a46fee8986ba02d9d2b56",
      "old_mode": 33188,
      "old_path": "mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.h",
      "new_id": "94db93d457a95b89afb94328d2de66befe74ef01",
      "new_mode": 33188,
      "new_path": "mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.h"
    },
    {
      "type": "modify",
      "old_id": "a47f59af79534be039925bda53b88ee89bc2a567",
      "old_mode": 33188,
      "old_path": "mojo/services/view_manager/public/cpp/lib/view_manager_context.cc",
      "new_id": "d1c2fd043d4930d38d329831312884e8b9ba7490",
      "new_mode": 33188,
      "new_path": "mojo/services/view_manager/public/cpp/lib/view_manager_context.cc"
    },
    {
      "type": "modify",
      "old_id": "456147cceb92d2f77edc2241fe65bdf448af6916",
      "old_mode": 33188,
      "old_path": "mojo/services/view_manager/public/cpp/lib/view_observer.cc",
      "new_id": "7e6acc0c3f36c44f60294a0c65c350d2acd0561b",
      "new_mode": 33188,
      "new_path": "mojo/services/view_manager/public/cpp/lib/view_observer.cc"
    },
    {
      "type": "modify",
      "old_id": "1c54567f155dae5e04bef8237d0c89ffa79a5c99",
      "old_mode": 33188,
      "old_path": "mojo/services/view_manager/public/cpp/lib/view_private.h",
      "new_id": "dc37196457f48943c93de64093dd65084d9fd911",
      "new_mode": 33188,
      "new_path": "mojo/services/view_manager/public/cpp/lib/view_private.h"
    },
    {
      "type": "modify",
      "old_id": "3414d33a0556172e6a1cb8ef45e1cba465bf6ca3",
      "old_mode": 33188,
      "old_path": "mojo/services/view_manager/public/cpp/tests/BUILD.gn",
      "new_id": "96810c67c2e510781e1890e65f93b225cf2e6187",
      "new_mode": 33188,
      "new_path": "mojo/services/view_manager/public/cpp/tests/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "ef8166159bcaf3ddc7c09b864ec0b612250f46a3",
      "old_mode": 33188,
      "old_path": "mojo/services/view_manager/public/cpp/tests/view_manager_test_suite.h",
      "new_id": "547efc2fe3f314a87e3533f39606c2b0942d586b",
      "new_mode": 33188,
      "new_path": "mojo/services/view_manager/public/cpp/tests/view_manager_test_suite.h"
    },
    {
      "type": "modify",
      "old_id": "bc694646fd8a020ac2ef286432d8f9be0926b130",
      "old_mode": 33188,
      "old_path": "mojo/services/view_manager/public/cpp/tests/view_manager_unittest.cc",
      "new_id": "fd08fabff7c60dabb965aac11c8c3c5dc67878e8",
      "new_mode": 33188,
      "new_path": "mojo/services/view_manager/public/cpp/tests/view_manager_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "149eb3a039e99bc79af8a582305fb5aeb8ff4c50",
      "old_mode": 33188,
      "old_path": "mojo/services/view_manager/public/cpp/tests/view_unittest.cc",
      "new_id": "abbd71255c2cc41f23c76a5b4d1f40d65f84e9a0",
      "new_mode": 33188,
      "new_path": "mojo/services/view_manager/public/cpp/tests/view_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "d888ef0998d80b4260f9d45cda1615b7969636a8",
      "old_mode": 33188,
      "old_path": "mojo/services/view_manager/public/cpp/view.h",
      "new_id": "a48dbc2066814261d2e2bb391d9ddf66eed75f05",
      "new_mode": 33188,
      "new_path": "mojo/services/view_manager/public/cpp/view.h"
    },
    {
      "type": "modify",
      "old_id": "edb5ca310091b363fd5ee5c54d00599332daf742",
      "old_mode": 33188,
      "old_path": "mojo/services/view_manager/public/cpp/view_manager_client_factory.h",
      "new_id": "e47da3d598bd9fab89338e29e81c17599d75ab4a",
      "new_mode": 33188,
      "new_path": "mojo/services/view_manager/public/cpp/view_manager_client_factory.h"
    },
    {
      "type": "modify",
      "old_id": "197659885c0aa968090b426cc33cd1a07fd1e0f1",
      "old_mode": 33188,
      "old_path": "mojo/services/view_manager/public/cpp/view_manager_context.h",
      "new_id": "de7b84bef5d75d8b76146a571b85b47b47b1962f",
      "new_mode": 33188,
      "new_path": "mojo/services/view_manager/public/cpp/view_manager_context.h"
    },
    {
      "type": "modify",
      "old_id": "f059e113ca81e0fdfe1233da6f38f4be3af33e15",
      "old_mode": 33188,
      "old_path": "mojo/services/view_manager/public/cpp/view_observer.h",
      "new_id": "341a4f0009471f260924c9cdb1909744fe9c2299",
      "new_mode": 33188,
      "new_path": "mojo/services/view_manager/public/cpp/view_observer.h"
    },
    {
      "type": "modify",
      "old_id": "d3a345fe9aea1327bb82afb9902920cdb72b7a06",
      "old_mode": 33188,
      "old_path": "mojo/services/view_manager/public/cpp/view_property.h",
      "new_id": "2dbd317b8cd3bf8a36967098222d45eb917b09ea",
      "new_mode": 33188,
      "new_path": "mojo/services/view_manager/public/cpp/view_property.h"
    },
    {
      "type": "modify",
      "old_id": "05325b7705e0cfd66b39e7b8793c3f448586687d",
      "old_mode": 33188,
      "old_path": "mojo/services/view_manager/public/cpp/view_tracker.h",
      "new_id": "1d6bf14de03e042affd898c7d356a442e6ca1e94",
      "new_mode": 33188,
      "new_path": "mojo/services/view_manager/public/cpp/view_tracker.h"
    },
    {
      "type": "modify",
      "old_id": "18d68e33e51ba86c46acc41df4135c34ebe25cec",
      "old_mode": 33188,
      "old_path": "services/window_manager/window_manager_app.cc",
      "new_id": "c35c5ff963b2fce9ad5980b73e40f4f15750f0be",
      "new_mode": 33188,
      "new_path": "services/window_manager/window_manager_app.cc"
    }
  ]
}