commit 85fe10953a6774127ec6756cedc2a6e42bbd8843
author Viet-Trung Luu <viettrungluu@chromium.org> Tue Mar 31 12:10:31 2015 -0700
committer Viet-Trung Luu <viettrungluu@chromium.org> Tue Mar 31 12:10:31 2015 -0700
tree 8ff87b8af5fa1f929f85aae32f6d7d2397a4fc7d
parent a417b14e9cd2b81a23dcf090d6110b1ec40bcd68

Shell: Remove ChildProcessHost::Delegate.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/1050613002

shell/child_process_host.h

diff --git a/shell/child_process_host.h b/shell/child_process_host.h
index 98909fa..fc4fff3 100644
--- a/shell/child_process_host.h
+++ b/shell/child_process_host.h
@@ -18,8 +18,7 @@
 
 // (Base) class for a "child process host". Handles launching and connecting a
 // platform-specific "pipe" to the child, and supports joining the child
-// process. Intended for use as a base class, but may be used on its own in
-// simple cases.
+// process.
 //
 // This class is not thread-safe. It should be created/used/destroyed on a
 // single thread.
@@ -27,19 +26,13 @@
 // Note: Does not currently work on Windows before Vista.
 class ChildProcessHost {
  public:
-  class Delegate {
-   public:
-    virtual void WillStart() = 0;
-    virtual void DidStart(bool success) = 0;
-  };
-
-  ChildProcessHost(Context* context, Delegate* delegate);
+  explicit ChildProcessHost(Context* context);
   virtual ~ChildProcessHost();
 
-  // |Start()|s the child process; calls the delegate's |DidStart()| (on the
-  // thread on which |Start()| was called) when the child has been started (or
-  // failed to start). After calling |Start()|, this object must not be
-  // destroyed until |DidStart()| has been called.
+  // |Start()|s the child process; calls |DidStart()| (on the thread on which
+  // |Start()| was called) when the child has been started (or failed to start).
+  // After calling |Start()|, this object must not be destroyed until
+  // |DidStart()| has been called.
   // TODO(vtl): Consider using weak pointers and removing this requirement.
   void Start();
 
@@ -52,15 +45,16 @@
     return &platform_channel_;
   }
 
+  virtual void WillStart() = 0;
+  virtual void DidStart(bool success) = 0;
+
  protected:
   Context* context() const { return context_; }
 
  private:
   bool DoLaunch();
-  void DidLaunch(bool success);
 
   Context* const context_;
-  Delegate* const delegate_;
 
   base::Process child_process_;