commit 8b78ea3ef3a6c9aeb9ba7064922c2c168174886a
author Aaron Boodman <aa@chromium.org> Wed Jan 21 09:28:10 2015 -0800
committer Aaron Boodman <aa@chromium.org> Wed Jan 21 09:28:10 2015 -0800
tree 925cd3d9a4e2a9aa21ddb385ab584487fad7127f
parent 371d089ce6e874afaa5f1f542b1e6da7184b4abb

De-client shell/application_manager/test.mojom

R=davemoore@chromium.org

Review URL: https://codereview.chromium.org/858273002

shell/application_manager/application_manager_unittest.cc

diff --git a/shell/application_manager/application_manager_unittest.cc b/shell/application_manager/application_manager_unittest.cc
index 9352a7d..a3addb7 100644
--- a/shell/application_manager/application_manager_unittest.cc
+++ b/shell/application_manager/application_manager_unittest.cc
@@ -61,38 +61,38 @@
   }
 
   // TestService implementation:
-  void Test(const String& test_string) override {
+  void Test(const String& test_string,
+            const mojo::Callback<void()>& callback) override {
     context_->last_test_string = test_string;
-    client()->AckTest();
+    callback.Run();
   }
 
  private:
   TestContext* context_;
 };
 
-class TestClientImpl : public TestClient {
+class TestClient {
  public:
-  explicit TestClientImpl(TestServicePtr service)
-      : service_(service.Pass()), quit_after_ack_(false) {
-    service_.set_client(this);
-  }
+  explicit TestClient(TestServicePtr service)
+      : service_(service.Pass()), quit_after_ack_(false) {}
 
-  ~TestClientImpl() override { service_.reset(); }
+  ~TestClient() { service_.reset(); }
 
-  void AckTest() override {
+  void AckTest() {
     if (quit_after_ack_)
       base::MessageLoop::current()->Quit();
   }
 
   void Test(const std::string& test_string) {
     quit_after_ack_ = true;
-    service_->Test(test_string);
+    service_->Test(test_string,
+                   base::Bind(&TestClient::AckTest, base::Unretained(this)));
   }
 
  private:
   TestServicePtr service_;
   bool quit_after_ack_;
-  DISALLOW_COPY_AND_ASSIGN(TestClientImpl);
+  DISALLOW_COPY_AND_ASSIGN(TestClient);
 };
 
 class TestApplicationLoader : public ApplicationLoader,
@@ -433,7 +433,7 @@
     TestServicePtr service_proxy;
     application_manager_->ConnectToService(GURL(kTestURLString),
                                            &service_proxy);
-    test_client_.reset(new TestClientImpl(service_proxy.Pass()));
+    test_client_.reset(new TestClient(service_proxy.Pass()));
   }
 
   void TearDown() override {
@@ -458,7 +458,7 @@
   TesterContext tester_context_;
   TestContext context_;
   base::MessageLoop loop_;
-  scoped_ptr<TestClientImpl> test_client_;
+  scoped_ptr<TestClient> test_client_;
   scoped_ptr<ApplicationManager> application_manager_;
   DISALLOW_COPY_AND_ASSIGN(ApplicationManagerTest);
 };
@@ -478,7 +478,7 @@
   am.SetLoaderForURL(scoped_ptr<ApplicationLoader>(loader), test_url);
   TestServicePtr test_service;
   am.ConnectToService(test_url, &test_service);
-  TestClientImpl test_client(test_service.Pass());
+  TestClient test_client(test_service.Pass());
   test_client.Test("test");
   loop_.Run();
   std::vector<std::string> app_args = loader->GetArgs();
@@ -498,7 +498,7 @@
   am.SetLoaderForURL(scoped_ptr<ApplicationLoader>(loader), test_url);
   TestServicePtr test_service;
   am.ConnectToService(test_url, &test_service);
-  TestClientImpl test_client(test_service.Pass());
+  TestClient test_client(test_service.Pass());
   test_client.Test("test");
   loop_.Run();
   std::vector<std::string> app_args = loader->GetArgs();