)]}'
{
  "commit": "9453c00348e8b8de237c8228e659e212dafb2b93",
  "tree": "8b8ce47b52f0ecd09a9fd6ba0237fde6969454bb",
  "parents": [
    "103f68e416fc15e16dab1ff20af2af5b1b5e01c1"
  ],
  "author": {
    "name": "Mitch Rudominer",
    "email": "rudominer@chromium.org",
    "time": "Tue Mar 22 08:39:07 2016 -0700"
  },
  "committer": {
    "name": "Mitch Rudominer",
    "email": "rudominer@chromium.org",
    "time": "Tue Mar 22 08:39:07 2016 -0700"
  },
  "message": "Mojom frontend: Allow non-reference types in non-zero versions of a struct.\n\nhttps://codereview.chromium.org/1823563002/ erroneously disallowed non-reference types in non-zero versions of a struct. This patch rectifies this problem, adds a test for it, and adds new sha1s and new generated .mojom.dart files.\n\n- We added the method AllowedInNonZeroStructVersion() to the TypeReference interface and we invoke that instead of the Nullable() method in computeVersionInfo().\n\n- We moved StructFieldMinVersionError from user_defined_types.go to computed_data.go where it belongs.\n\nBUG\u003d#713\nR\u003dazani@chromium.org\n\nReview URL: https://codereview.chromium.org/1819223002 .\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "6ecc46603af86d4c8efb399235574c1ea1659d54",
      "old_mode": 33188,
      "old_path": "mojo/dart/packages/_mojo_for_test_only/lib/dart_to_cpp/dart_to_cpp.mojom.dart",
      "new_id": "3a38a555585e20509f2bd55b188c0cbbea870416",
      "new_mode": 33188,
      "new_path": "mojo/dart/packages/_mojo_for_test_only/lib/dart_to_cpp/dart_to_cpp.mojom.dart"
    },
    {
      "type": "modify",
      "old_id": "245f669a9053b00d8c3532cd6578583bb43d0ba3",
      "old_mode": 33188,
      "old_path": "mojo/dart/packages/_mojo_for_test_only/lib/imported/sample_import.mojom.dart",
      "new_id": "c682f00c14155422581e28d8436bc4f0ed579036",
      "new_mode": 33188,
      "new_path": "mojo/dart/packages/_mojo_for_test_only/lib/imported/sample_import.mojom.dart"
    },
    {
      "type": "modify",
      "old_id": "8803e4313e8a071aa05f420be194931833ce859f",
      "old_mode": 33188,
      "old_path": "mojo/dart/packages/_mojo_for_test_only/lib/imported/sample_import2.mojom.dart",
      "new_id": "209e2e234669ef784bfe1744bc7f057de702a3f6",
      "new_mode": 33188,
      "new_path": "mojo/dart/packages/_mojo_for_test_only/lib/imported/sample_import2.mojom.dart"
    },
    {
      "type": "modify",
      "old_id": "e2d9c761b202fa09148165a94cf0a766d85618ec",
      "old_mode": 33188,
      "old_path": "mojo/dart/packages/_mojo_for_test_only/lib/math/math_calculator.mojom.dart",
      "new_id": "63ed499295b9fca063fafda9f31d0eee63067ff2",
      "new_mode": 33188,
      "new_path": "mojo/dart/packages/_mojo_for_test_only/lib/math/math_calculator.mojom.dart"
    },
    {
      "type": "modify",
      "old_id": "c13cba81ba4931703803e32bb7af09cd325defd1",
      "old_mode": 33188,
      "old_path": "mojo/dart/packages/_mojo_for_test_only/lib/mojo/examples/echo.mojom.dart",
      "new_id": "4153ab1a754dd9699c76adffc45170f4871a8d7f",
      "new_mode": 33188,
      "new_path": "mojo/dart/packages/_mojo_for_test_only/lib/mojo/examples/echo.mojom.dart"
    },
    {
      "type": "modify",
      "old_id": "07bab67e397e4ed1cf2fac9dfc4886b7672362db",
      "old_mode": 33188,
      "old_path": "mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/rect.mojom.dart",
      "new_id": "8f30c4b9de86b13c7c98c774bd46c803a8dbda55",
      "new_mode": 33188,
      "new_path": "mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/rect.mojom.dart"
    },
    {
      "type": "modify",
      "old_id": "b33beaefb75758af5db509bd94e0864ee73475f9",
      "old_mode": 33188,
      "old_path": "mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/serialization_test_structs.mojom.dart",
      "new_id": "4dcdca669b083b379d408a57cba66a559740a675",
      "new_mode": 33188,
      "new_path": "mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/serialization_test_structs.mojom.dart"
    },
    {
      "type": "modify",
      "old_id": "f237eca7698cdb87095bb61f36a4ec48e4ccfeaa",
      "old_mode": 33188,
      "old_path": "mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/test_enums.mojom.dart",
      "new_id": "50939fde37cb221ce6729341c8d77eeb6028c7c4",
      "new_mode": 33188,
      "new_path": "mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/test_enums.mojom.dart"
    },
    {
      "type": "modify",
      "old_id": "4697bd54604a3115ae97f9798287ca3133e0dc61",
      "old_mode": 33188,
      "old_path": "mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/test_included_unions.mojom.dart",
      "new_id": "bf5bda8fe14520d09701abb8c35984401b9d000c",
      "new_mode": 33188,
      "new_path": "mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/test_included_unions.mojom.dart"
    },
    {
      "type": "modify",
      "old_id": "98bbcf20cfb33e2fafa7e85354b5174651f2855e",
      "old_mode": 33188,
      "old_path": "mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/test_structs.mojom.dart",
      "new_id": "f3208bfbf98e55093e0cebf71ddace3cdeb21cf8",
      "new_mode": 33188,
      "new_path": "mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/test_structs.mojom.dart"
    },
    {
      "type": "modify",
      "old_id": "deb830ca81b51b7b2ec840f3f1d428f05fb295bc",
      "old_mode": 33188,
      "old_path": "mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/test_unions.mojom.dart",
      "new_id": "782c7fd9893483b380576b68f0ca27064633234b",
      "new_mode": 33188,
      "new_path": "mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/test_unions.mojom.dart"
    },
    {
      "type": "modify",
      "old_id": "6cb130a1a516d560114e7b2a80d64953bb8ddd3b",
      "old_mode": 33188,
      "old_path": "mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/validation_test_interfaces.mojom.dart",
      "new_id": "cea781abf87f0a5ad5c196e3c6e48780a5563c9a",
      "new_mode": 33188,
      "new_path": "mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/validation_test_interfaces.mojom.dart"
    },
    {
      "type": "modify",
      "old_id": "a872df60a2b75be612c7a00165b8ad8c4aa44ed5",
      "old_mode": 33188,
      "old_path": "mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/versioning/versioning_test_client.mojom.dart",
      "new_id": "951b229c28adad48a087fdb0132cb4229720e025",
      "new_mode": 33188,
      "new_path": "mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/versioning/versioning_test_client.mojom.dart"
    },
    {
      "type": "modify",
      "old_id": "1388572262cc7062fc4343471e0f60c2b2309300",
      "old_mode": 33188,
      "old_path": "mojo/dart/packages/_mojo_for_test_only/lib/regression_tests/regression_tests.mojom.dart",
      "new_id": "2e46cb5112297547ab3c56a761421b706ecde661",
      "new_mode": 33188,
      "new_path": "mojo/dart/packages/_mojo_for_test_only/lib/regression_tests/regression_tests.mojom.dart"
    },
    {
      "type": "modify",
      "old_id": "64e8a3ad2b3a4ba8c9bf4415d352f3be46e6e629",
      "old_mode": 33188,
      "old_path": "mojo/dart/packages/_mojo_for_test_only/lib/sample/sample_factory.mojom.dart",
      "new_id": "08a04869d372f58a6a1c7d38197f2d42c93d5ac9",
      "new_mode": 33188,
      "new_path": "mojo/dart/packages/_mojo_for_test_only/lib/sample/sample_factory.mojom.dart"
    },
    {
      "type": "modify",
      "old_id": "be8c092f3f4a7d645b75fe62fc795e7458856863",
      "old_mode": 33188,
      "old_path": "mojo/dart/packages/_mojo_for_test_only/lib/sample/sample_interfaces.mojom.dart",
      "new_id": "79b5f9160ece8ab6998681be031f476365007392",
      "new_mode": 33188,
      "new_path": "mojo/dart/packages/_mojo_for_test_only/lib/sample/sample_interfaces.mojom.dart"
    },
    {
      "type": "modify",
      "old_id": "c9ccc5b8f868fab4044a5f5785d4884aad4b72eb",
      "old_mode": 33188,
      "old_path": "mojo/dart/packages/_mojo_for_test_only/lib/sample/sample_service.mojom.dart",
      "new_id": "c5a0e666089eb406f2098b0bff04b2cd4c0b2fd4",
      "new_mode": 33188,
      "new_path": "mojo/dart/packages/_mojo_for_test_only/lib/sample/sample_service.mojom.dart"
    },
    {
      "type": "modify",
      "old_id": "1b0165fd2e8466f66b978d1d51ce27ed3ece30cd",
      "old_mode": 33188,
      "old_path": "mojo/dart/packages/_mojo_for_test_only/lib/test/echo_service.mojom.dart",
      "new_id": "bc9955a89a04624c10fc16eef844a36e106db2ef",
      "new_mode": 33188,
      "new_path": "mojo/dart/packages/_mojo_for_test_only/lib/test/echo_service.mojom.dart"
    },
    {
      "type": "modify",
      "old_id": "ec023ff7fdfd3f1fd81f0376c94a2f71f25b1a67",
      "old_mode": 33188,
      "old_path": "mojo/dart/packages/_mojo_for_test_only/lib/test/pingpong_service.mojom.dart",
      "new_id": "e05112751c8d38d5775a1742480ffc2cdcd837c5",
      "new_mode": 33188,
      "new_path": "mojo/dart/packages/_mojo_for_test_only/lib/test/pingpong_service.mojom.dart"
    },
    {
      "type": "modify",
      "old_id": "11c258f2b37636644f261cd787a5a7947b9d61be",
      "old_mode": 33188,
      "old_path": "mojo/public/tools/bindings/mojom_tool/bin/linux64/mojom.sha1",
      "new_id": "5bc7186be40d7ca13fc12a48b6a40c3b9a1fd1db",
      "new_mode": 33188,
      "new_path": "mojo/public/tools/bindings/mojom_tool/bin/linux64/mojom.sha1"
    },
    {
      "type": "modify",
      "old_id": "07cf6f7121ac6b1f0c8160775a179356373d85da",
      "old_mode": 33188,
      "old_path": "mojo/public/tools/bindings/mojom_tool/bin/mac64/mojom.sha1",
      "new_id": "f8f67ea397caa668dd76fedf41a51398515578e5",
      "new_mode": 33188,
      "new_path": "mojo/public/tools/bindings/mojom_tool/bin/mac64/mojom.sha1"
    },
    {
      "type": "modify",
      "old_id": "1064a6e3dd85d856b0c02dd9b43bfff99642b857",
      "old_mode": 33188,
      "old_path": "mojom/mojom_parser/mojom/computed_data.go",
      "new_id": "e0a3438666b90e092616db8f82d78a5110d068d3",
      "new_mode": 33188,
      "new_path": "mojom/mojom_parser/mojom/computed_data.go"
    },
    {
      "type": "modify",
      "old_id": "c8af282f058355cbecf0b3ac8996886e2a9d8261",
      "old_mode": 33188,
      "old_path": "mojom/mojom_parser/mojom/types.go",
      "new_id": "4917148da4b38faca2b02657ea9efa4f688dc628",
      "new_mode": 33188,
      "new_path": "mojom/mojom_parser/mojom/types.go"
    },
    {
      "type": "modify",
      "old_id": "6f6b877d2cf6d30cfa234b3720a0934cf195c13f",
      "old_mode": 33188,
      "old_path": "mojom/mojom_parser/mojom/user_defined_types.go",
      "new_id": "6d1833b951c4f6eae9208bd1b086024d8648294b",
      "new_mode": 33188,
      "new_path": "mojom/mojom_parser/mojom/user_defined_types.go"
    },
    {
      "type": "modify",
      "old_id": "012e39aea4ac6fa2ea48c523116d68c1e44a80bd",
      "old_mode": 33188,
      "old_path": "mojom/mojom_parser/parser/computed_data_test.go",
      "new_id": "2f4bb1ff8ce3521b880b0298c0a557679d4bf84a",
      "new_mode": 33188,
      "new_path": "mojom/mojom_parser/parser/computed_data_test.go"
    },
    {
      "type": "modify",
      "old_id": "c4f1d3ce9d734fe12be3f21a03deb77d12e4fd02",
      "old_mode": 33188,
      "old_path": "mojom/mojom_parser/serialization/serialization_test.go",
      "new_id": "baf834c57399bd8eb6d3a3db5a7dd47f2a3affc9",
      "new_mode": 33188,
      "new_path": "mojom/mojom_parser/serialization/serialization_test.go"
    }
  ]
}