)]}'
{
  "commit": "a241773121e1588ad04f5d970a6ccc42ad52bc00",
  "tree": "f707ba86ba63f064d0dfe07388c28dbe25b7020d",
  "parents": [
    "511fb91ce473ad4e74090835b157316354011ea3"
  ],
  "author": {
    "name": "Alex Fandrianto",
    "email": "alexfandrianto@google.com",
    "time": "Wed Jan 06 12:13:11 2016 -0800"
  },
  "committer": {
    "name": "Alex Fandrianto",
    "email": "alexfandrianto@google.com",
    "time": "Wed Jan 06 12:13:11 2016 -0800"
  },
  "message": "Simplify Go\u0027s Mojom Type Generator\n\nRemoves all dependence on the identifier_store.\n\nOriginally, the identifier_store appeared to be needed because types were generated recursively, and their children types also needed to be registered. In order to break cycles and avoid repeats, we would use the identifier_store.\n\nHowever, this is actually not needed. Each relevant type to be registered (enum/union/struct/interface) is already known beforehand by the generating Python script. Types belonging to other .mojom files are also registered explicitly. Since children types do NOT need to be registered, the identifier_store could be safely removed.\n\nThis CL also shifts the generation flag from the go generator to the generator scripts. This is a better location since it allows users to control whether types are generated or not.\n\nBUG\u003dhttps://github.com/domokit/mojo/issues/596\nR\u003dazani@chromium.org\n\nReview URL: https://codereview.chromium.org/1508293004 .\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "d93f9024f3635af6c8ff60adb9cd2c047821e96e",
      "old_mode": 33188,
      "old_path": "mojo/public/tools/bindings/generators/go_templates/mojom_reference_macros.tmpl",
      "new_id": "fc130252c0f84681948da6545a3250de4e186906",
      "new_mode": 33188,
      "new_path": "mojo/public/tools/bindings/generators/go_templates/mojom_reference_macros.tmpl"
    },
    {
      "type": "modify",
      "old_id": "e6ba23da2fe6689d514c234263791961b67a96aa",
      "old_mode": 33188,
      "old_path": "mojo/public/tools/bindings/generators/go_templates/mojom_type_macros.tmpl",
      "new_id": "9424545120dd562fe592e3799836975a1bcb24cf",
      "new_mode": 33188,
      "new_path": "mojo/public/tools/bindings/generators/go_templates/mojom_type_macros.tmpl"
    },
    {
      "type": "modify",
      "old_id": "d0687784ddd7f78f81254cf733253c6e0c4e84ff",
      "old_mode": 33188,
      "old_path": "mojo/public/tools/bindings/generators/mojom_go_generator.py",
      "new_id": "709bcc63021f56a760456e6ecd685cb958143aac",
      "new_mode": 33188,
      "new_path": "mojo/public/tools/bindings/generators/mojom_go_generator.py"
    },
    {
      "type": "modify",
      "old_id": "554db742aa085fca26985b6b01b841c7a5bb76c2",
      "old_mode": 33188,
      "old_path": "mojo/public/tools/bindings/generators/mojom_java_generator.py",
      "new_id": "12e193a6f493348febd0efad0394808e4640f884",
      "new_mode": 33188,
      "new_path": "mojo/public/tools/bindings/generators/mojom_java_generator.py"
    },
    {
      "type": "modify",
      "old_id": "6b455b3d54496401635272a4efd70f7a465a2a65",
      "old_mode": 33261,
      "old_path": "mojo/public/tools/bindings/mojom_bindings_generator_v1.py",
      "new_id": "a692092267c6007489acbc1064470048efeea491",
      "new_mode": 33261,
      "new_path": "mojo/public/tools/bindings/mojom_bindings_generator_v1.py"
    },
    {
      "type": "modify",
      "old_id": "a6d30946a1dd44a94729a9157dad5945e5e9a622",
      "old_mode": 33261,
      "old_path": "mojo/public/tools/bindings/run_code_generators.py",
      "new_id": "3448ca4374e9aca57b7cddc1889e7934c07169e2",
      "new_mode": 33261,
      "new_path": "mojo/public/tools/bindings/run_code_generators.py"
    }
  ]
}
