)]}'
{
  "commit": "bfc1118ae801b4142f4027cd3cb1ab079c325f66",
  "tree": "b0fab83c053734ac52795374044be45cd04d1426",
  "parents": [
    "736e0cc30313290b17243d7a6513fcc8e12821a2"
  ],
  "author": {
    "name": "Aaron Boodman",
    "email": "aa@chromium.org",
    "time": "Thu Feb 19 12:42:19 2015 -0800"
  },
  "committer": {
    "name": "Aaron Boodman",
    "email": "aa@chromium.org",
    "time": "Thu Feb 19 12:42:19 2015 -0800"
  },
  "message": "Simplify the ApplicationLoader interface in preparation for changes.\n\nThe ApplicationLoader interface has become very complicated because it\nprovides a way for clients of ApplicationManager to do two different\nthings in response to a connection request.\n\n1. Bind to an Application implementation.\n\n2. Delegate back to ApplicationManager with details about a\n   ContentHandler to use instead.\n\nApplicationLoader was originally designed to do only #1. I extended it\nto do #2 in the misguided thought that it would be nice for\nApplicationLoader implementations to be able to provide content for a\nContentHandler as well actual applications.\n\nHowever, this second use case was never needed and adds lots of\ncomplexity.\n\nI think it will simplify things dramatically to move URL fetching and\nContentHandler handling into application manager directly. If we ever\nneed to generalize that behavior, we can create a separate interface\nfrom ApplicationLoader for it at that time.\n\nThis CL is a first step that is pretty mechanical in nature, but I\nthink is still an improvement. Suggest reviewing in the following\norder:\n\n- application_loader.*\n- application_manager.*\n- everything else\n\nThe next change will break apart DynamicApplicationLoader into pieces\nwhich will be used from within ApplicationManager.\n\nR\u003ddavemoore@chromium.org\n\nReview URL: https://codereview.chromium.org/930243006\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "08fd544c8f72150f954e90138822c0408c90ce53",
      "old_mode": 33188,
      "old_path": "PRESUBMIT.py",
      "new_id": "00995e8337ac8666a9f8b5306f37d7de51076412",
      "new_mode": 33188,
      "new_path": "PRESUBMIT.py"
    },
    {
      "type": "modify",
      "old_id": "a8f8d6a452410095ab4a100fa8c42bae67919205",
      "old_mode": 33188,
      "old_path": "services/window_manager/window_manager_api_unittest.cc",
      "new_id": "dbd3da641092dcd8ec761e62aed63e2d1892e4b6",
      "new_mode": 33188,
      "new_path": "services/window_manager/window_manager_api_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "800ad70351877cd9d65a31d76850bac268d8b927",
      "old_mode": 33188,
      "old_path": "shell/BUILD.gn",
      "new_id": "7c7ae604ab83e6a0b9a5c524f1a2b9ae7cde93d6",
      "new_mode": 33188,
      "new_path": "shell/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "1b334f317e2a5f917d242676b98c4f4383bceb72",
      "old_mode": 33188,
      "old_path": "shell/android/android_handler_loader.cc",
      "new_id": "abbf8d70746a597ec24a8c1d0f66e6b14e0dcc69",
      "new_mode": 33188,
      "new_path": "shell/android/android_handler_loader.cc"
    },
    {
      "type": "modify",
      "old_id": "66961389562bd800b93b01d67a82668282c9c48b",
      "old_mode": 33188,
      "old_path": "shell/android/android_handler_loader.h",
      "new_id": "1b209a4f5d7f6ad9d08af2e4b50d87205a762b57",
      "new_mode": 33188,
      "new_path": "shell/android/android_handler_loader.h"
    },
    {
      "type": "modify",
      "old_id": "8f3c21b2abdffec41444d96dfdd4449f5f1be45d",
      "old_mode": 33188,
      "old_path": "shell/android/background_application_loader.cc",
      "new_id": "23895152f6ddbef2a65f38f37a13b754b7d716f4",
      "new_mode": 33188,
      "new_path": "shell/android/background_application_loader.cc"
    },
    {
      "type": "modify",
      "old_id": "a4c07b84df2e2c14073437a774d712c423197607",
      "old_mode": 33188,
      "old_path": "shell/android/background_application_loader.h",
      "new_id": "850b9009a20e3fd9757f7e7cebb6aa02eedfb414",
      "new_mode": 33188,
      "new_path": "shell/android/background_application_loader.h"
    },
    {
      "type": "modify",
      "old_id": "62e9234e9e5a45c66bf23e9dedd16e4ed868c16b",
      "old_mode": 33188,
      "old_path": "shell/android/background_application_loader_unittest.cc",
      "new_id": "5a6360dedbf1e8fbd8b0a1853cda059d9d67ecee",
      "new_mode": 33188,
      "new_path": "shell/android/background_application_loader_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "cd27ba472375c835efef6ef5a182e18aad77d267",
      "old_mode": 33188,
      "old_path": "shell/android/native_viewport_application_loader.cc",
      "new_id": "3e8c76e80e27d67d48f9ecb2d1787d4f1fe9662b",
      "new_mode": 33188,
      "new_path": "shell/android/native_viewport_application_loader.cc"
    },
    {
      "type": "modify",
      "old_id": "773c4e4f0dc09b26287c54a697dc7caa3dcc8a59",
      "old_mode": 33188,
      "old_path": "shell/android/native_viewport_application_loader.h",
      "new_id": "13e3e8c9d59387b0e9d2dfa2dc5a86ab1667ef25",
      "new_mode": 33188,
      "new_path": "shell/android/native_viewport_application_loader.h"
    },
    {
      "type": "modify",
      "old_id": "a9eacffaa2c79e67b3b1e189de56b3d7559a6a4d",
      "old_mode": 33188,
      "old_path": "shell/android/ui_application_loader_android.cc",
      "new_id": "fff625198400fc78884ba62859306855e22c7625",
      "new_mode": 33188,
      "new_path": "shell/android/ui_application_loader_android.cc"
    },
    {
      "type": "modify",
      "old_id": "e7933c60e08b9605156a7297ae9ef9b7ac8a995a",
      "old_mode": 33188,
      "old_path": "shell/android/ui_application_loader_android.h",
      "new_id": "06ccc09c8e9aa3a3c0dd0df4d60a9dbf9a127b21",
      "new_mode": 33188,
      "new_path": "shell/android/ui_application_loader_android.h"
    },
    {
      "type": "modify",
      "old_id": "1e32a5a71360129993cd11f7b61146342c26af9e",
      "old_mode": 33188,
      "old_path": "shell/application_manager/application_loader.cc",
      "new_id": "6cbf03211dc26feb8d5dbbb07f366dbad3a24704",
      "new_mode": 33188,
      "new_path": "shell/application_manager/application_loader.cc"
    },
    {
      "type": "modify",
      "old_id": "b081819cd80e614fd6c9994f776d9dc760121493",
      "old_mode": 33188,
      "old_path": "shell/application_manager/application_loader.h",
      "new_id": "9e39de14dbdc647c450b0194235519697a987494",
      "new_mode": 33188,
      "new_path": "shell/application_manager/application_loader.h"
    },
    {
      "type": "modify",
      "old_id": "f0c4bac91d2d1e031750b61db2ab00761e1c8a0f",
      "old_mode": 33188,
      "old_path": "shell/application_manager/application_manager.cc",
      "new_id": "255c0935590a2d7de975dc515f65450f98ea8d3e",
      "new_mode": 33188,
      "new_path": "shell/application_manager/application_manager.cc"
    },
    {
      "type": "modify",
      "old_id": "ab6b2f079792b2e06ba09badbe3bd11a5dfaa18a",
      "old_mode": 33188,
      "old_path": "shell/application_manager/application_manager.h",
      "new_id": "e8858e1c2ef19d2f18d66482ec89ae73f7fad8cc",
      "new_mode": 33188,
      "new_path": "shell/application_manager/application_manager.h"
    },
    {
      "type": "modify",
      "old_id": "0481e741ad2824787cb1135908cb323332224f6b",
      "old_mode": 33188,
      "old_path": "shell/application_manager/application_manager_unittest.cc",
      "new_id": "4c8368b362c763e416676e9eeeecbebbf1e90320",
      "new_mode": 33188,
      "new_path": "shell/application_manager/application_manager_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "0c439441228ca4b2e6bfcb88826a39383b694ffa",
      "old_mode": 33188,
      "old_path": "shell/context.cc",
      "new_id": "0707cefe6e7018d40dd6cbc65ece41096b358dec",
      "new_mode": 33188,
      "new_path": "shell/context.cc"
    },
    {
      "type": "modify",
      "old_id": "5bd8ecde04da24ad6c449e668ebbc398d3bcb325",
      "old_mode": 33188,
      "old_path": "shell/context.h",
      "new_id": "4d2cf341aa9dacf52db7cec46e2d4c5249728779",
      "new_mode": 33188,
      "new_path": "shell/context.h"
    },
    {
      "type": "modify",
      "old_id": "e841486fdc660823e4981b8029fb5e624fe188f5",
      "old_mode": 33188,
      "old_path": "shell/external_application_listener_unittest.cc",
      "new_id": "0678ab8645625033416f346974e8048c56cc0340",
      "new_mode": 33188,
      "new_path": "shell/external_application_listener_unittest.cc"
    },
    {
      "type": "rename",
      "old_id": "afc9a5395c241d4861400bc0d6feb4cddba02956",
      "old_mode": 33188,
      "old_path": "shell/dynamic_application_loader.cc",
      "new_id": "f7960ca25321e388a6bf1b81fdbb948a4b92b0ec",
      "new_mode": 33188,
      "new_path": "shell/native_application_loader.cc",
      "score": 92
    },
    {
      "type": "rename",
      "old_id": "e91bcea29bb025a94343e8668eb1e8375802f974",
      "old_mode": 33188,
      "old_path": "shell/dynamic_application_loader.h",
      "new_id": "db665994dc78c6693604fb96bae16d0e11215245",
      "new_mode": 33188,
      "new_path": "shell/native_application_loader.h",
      "score": 68
    },
    {
      "type": "rename",
      "old_id": "833e4757a90595b0c1c73656dea928faa6f9a015",
      "old_mode": 33188,
      "old_path": "shell/dynamic_application_loader_unittest.cc",
      "new_id": "473412a91e6c598fb5f8c9a3029cc7171dc57ff8",
      "new_mode": 33188,
      "new_path": "shell/native_application_loader_unittest.cc",
      "score": 82
    }
  ]
}