tree b0fab83c053734ac52795374044be45cd04d1426
parent 736e0cc30313290b17243d7a6513fcc8e12821a2
author Aaron Boodman <aa@chromium.org> 1424378539 -0800
committer Aaron Boodman <aa@chromium.org> 1424378539 -0800

Simplify the ApplicationLoader interface in preparation for changes.

The ApplicationLoader interface has become very complicated because it
provides a way for clients of ApplicationManager to do two different
things in response to a connection request.

1. Bind to an Application implementation.

2. Delegate back to ApplicationManager with details about a
   ContentHandler to use instead.

ApplicationLoader was originally designed to do only #1. I extended it
to do #2 in the misguided thought that it would be nice for
ApplicationLoader implementations to be able to provide content for a
ContentHandler as well actual applications.

However, this second use case was never needed and adds lots of
complexity.

I think it will simplify things dramatically to move URL fetching and
ContentHandler handling into application manager directly. If we ever
need to generalize that behavior, we can create a separate interface
from ApplicationLoader for it at that time.

This CL is a first step that is pretty mechanical in nature, but I
think is still an improvement. Suggest reviewing in the following
order:

- application_loader.*
- application_manager.*
- everything else

The next change will break apart DynamicApplicationLoader into pieces
which will be used from within ApplicationManager.

R=davemoore@chromium.org

Review URL: https://codereview.chromium.org/930243006