)]}'
{
  "commit": "dd035f53e654d1c22fd30ffdca777f378e591ca6",
  "tree": "2bb932ab0d73eab454cde13ed9e18ad74105a8cb",
  "parents": [
    "191805569772d5bfdc8a35329f51b4f05d27f32c"
  ],
  "author": {
    "name": "Scott Violet",
    "email": "sky@chromium.org",
    "time": "Thu Dec 18 08:47:12 2014 -0800"
  },
  "committer": {
    "name": "Scott Violet",
    "email": "sky@chromium.org",
    "time": "Thu Dec 18 08:47:12 2014 -0800"
  },
  "message": "Removes BackgroundShellApplicationLoader from application_manager tests\n\nBackgroundShellApplicationLoader is android specific. I\u0027m removing use\nfrom application_manager_unittests so that I can move\nBackgroundShellApplicationLoader (see\nhttps://codereview.chromium.org/788243007/ ). There is only one test\nin application_manager_unittests that relied on\nBackgroundShellApplicationLoader: BDeleted.\n\nBDeleted needed BackgroundShellApplicationLoader because resetting the\nloader (BackgroundShellApplicationLoader) triggered shutting down\nthe background thread and background message loop (owned by\nBackgroundShellApplicationLoader). Shutting down the MessageLoop\ncloses any pipes. As A/B are InterfaceImpls they are destroyed when\nthe pipe closes. Removing BackgroundShellApplicationLoader breaks\nBDeleted because resetting the loader no longer triggers closing\npipes. The fix is to make Tester own the TestAImpls it creates. This\nway when the test resets the loader the TestAImpls are destroyed so\nthat the other side (TestBimpl) sees the connection error and cleans\nup.\n\nBUG\u003dnone\nTEST\u003dnone\nR\u003dqsr@chromium.org, davemoore@chromium.org\n\nReview URL: https://codereview.chromium.org/812083002\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "c276f2e4d0b8911b73138bae6ddab919182ba6e9",
      "old_mode": 33188,
      "old_path": "mojo/application_manager/application_manager_unittest.cc",
      "new_id": "5bbe4a62ce5de32349dcc58a51ba729bf668b2d0",
      "new_mode": 33188,
      "new_path": "mojo/application_manager/application_manager_unittest.cc"
    }
  ]
}
