commit e126c86bc85bc9a2b8a0951a1573c45a03e12c18
author Viet-Trung Luu <viettrungluu@chromium.org> Mon Mar 30 19:20:45 2015 -0700
committer Viet-Trung Luu <viettrungluu@chromium.org> Mon Mar 30 19:20:45 2015 -0700
tree 19dd4f6b85bb265a3238e8003313adf502ddfa6d
parent bb7095ab2314ef45e6350528c98b2504efbabc53

Split LoadAndRunNativeApplication() ...

(... to separate LoadNativeApplication() and RunNativeApplication()).

* This is to better support sandboxing in the near future. (Note: All
  the thunks are set in RunNativeApplication(). This should be fine with
  respect to sandboxing. More questionable is the calling of
  InitGoRuntime() (though this is supposedly temporary). We'll worry
  about that if it ever becomes a problem.)
* Also rename the files from dynamic_service_runner.* to
  native_application_support.*.
* Also make a separate native_application_support target. (The inclusion
  of dynamic_service_runner.* in the in_process_native_runner target was
  never really right anyway.
* Remove the (trivial -- just for an enum declaration) dependency of
  native_application_support.* on application_manager. This is so the
  future mojo_shell_child binary won't need to depend on half the world,
  and thus link in dynamic libraries it may not need.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/1046013002

shell/application_manager/application_manager.h

diff --git a/shell/application_manager/application_manager.h b/shell/application_manager/application_manager.h
index 3bcbc0c..5a72c85 100644
--- a/shell/application_manager/application_manager.h
+++ b/shell/application_manager/application_manager.h
@@ -18,6 +18,7 @@
 #include "shell/application_manager/application_loader.h"
 #include "shell/application_manager/identity.h"
 #include "shell/application_manager/native_runner.h"
+#include "shell/native_application_support.h"
 #include "url/gurl.h"
 
 namespace base {
@@ -182,12 +183,12 @@
                            ServiceProviderPtr exposed_services,
                            const base::Closure& on_application_end,
                            const std::vector<std::string>& parameters,
-                           NativeRunner::CleanupBehavior cleanup_behavior,
+                           NativeApplicationCleanup cleanup,
                            scoped_ptr<Fetcher> fetcher);
 
   void RunNativeApplication(InterfaceRequest<Application> application_request,
                             const NativeRunnerFactory::Options& options,
-                            NativeRunner::CleanupBehavior cleanup_behavior,
+                            NativeApplicationCleanup cleanup,
                             scoped_ptr<Fetcher> fetcher,
                             const base::FilePath& file_path,
                             bool path_exists);