commit e8ca9b7e4ac915477f80523c7fbbc8702bdcc46b
author Benjamin Lerman <qsr@chromium.org> Tue Feb 24 16:42:13 2015 +0100
committer Benjamin Lerman <qsr@chromium.org> Tue Feb 24 16:42:13 2015 +0100
tree 22dc5bb89759488beaf8d3b6599f224a6ad4b65e
parent cfaeb4a892e7ab1dbd9a9cd7a246fee4c9408540

Update from https://crrev.com/317530

TBR=qsr@chromium.org
BUG=461092

Review URL: https://codereview.chromium.org/952893003

base/version.cc

diff --git a/base/version.cc b/base/version.cc
index 6318b35..933356e 100644
--- a/base/version.cc
+++ b/base/version.cc
@@ -31,6 +31,8 @@
 
   for (std::vector<std::string>::const_iterator it = numbers.begin();
        it != numbers.end(); ++it) {
+    if (StartsWithASCII(*it, "+", false))
+      return false;
     int num;
     if (!StringToInt(*it, &num))
       return false;
@@ -42,8 +44,8 @@
     if (num > max)
       return false;
 
-    // This throws out things like +3, or 032.
-    if (IntToString(num) != *it)
+    // This throws out leading zeros for the first item only.
+    if (it == numbers.begin() && IntToString(num) != *it)
       return false;
 
     parsed->push_back(static_cast<uint16>(num));