)]}'
{
  "commit": "8945984fcfe6f45ee825417a47e0d2d0451aee1d",
  "tree": "0ffc8bd19b9c8bcbb0d4c897246d7c8a8afbfd92",
  "parents": [
    "c747b91aa53c244740e99d5b41994535cce2a658"
  ],
  "author": {
    "name": "Viet-Trung Luu",
    "email": "viettrungluu@chromium.org",
    "time": "Wed Jun 22 09:16:44 2016 -0700"
  },
  "committer": {
    "name": "Viet-Trung Luu",
    "email": "viettrungluu@chromium.org",
    "time": "Wed Jun 22 09:16:44 2016 -0700"
  },
  "message": "Rationalize AddAwakable...() and RemoveAwakable...() methods.\n\nDespite the apparent size of this change, it\u0027s just one big make-work\nproject. But it\u0027ll help preserve (what little is left of) my sanity.\n\n* Rearrange the order of parameters, so that the context always\n  immediately follows the awakable pointer argument.\n* Give Dispatcher::AddAwakable() a |force| parameter, like everywhere\n  else, and get rid of its AddAwakableUnconditional().\n* Give all the RemoveAwakable() (and similar variants) methods in\n  various places a |match_context| boolean parameter and a |context|\n  parameter (used only if |match_context| is true), and get rid of\n  RemoveAwakableWithContext() (and similar variants).\n* Change the behaviour of AddAwakable() when |force| is true, to also\n  add when something is (currently) never-satisfiable. (Data pipe\n  consumer/producers can sometimes go from \"never\"-satisfiable back to\n  satisfiable due to a change of options.)\n\nR\u003dvardhan@google.com\nBUG\u003d#350\n\nReview URL: https://codereview.chromium.org/2084593005 .\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "b3e2763823ef811b2d58aba986649e8118e5270c",
      "old_mode": 33188,
      "old_path": "mojo/edk/system/awakable_list.cc",
      "new_id": "fb432b91dc67dc087e34d82a9cab792558402277",
      "new_mode": 33188,
      "new_path": "mojo/edk/system/awakable_list.cc"
    },
    {
      "type": "modify",
      "old_id": "7e4b732ad1c662c7bf4fa6fe8712f9063325cb8d",
      "old_mode": 33188,
      "old_path": "mojo/edk/system/awakable_list.h",
      "new_id": "d1e947dfd464e397f230dd0dc13dc6d3d10f078e",
      "new_mode": 33188,
      "new_path": "mojo/edk/system/awakable_list.h"
    },
    {
      "type": "modify",
      "old_id": "d193e5c85b006104286275288087173a442d9a22",
      "old_mode": 33188,
      "old_path": "mojo/edk/system/awakable_list_unittest.cc",
      "new_id": "2f8c619e8c6e4c5bccaef7f978dbb8f430326924",
      "new_mode": 33188,
      "new_path": "mojo/edk/system/awakable_list_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "6051f40416eb29d971ea83ae2bb1ee8773b357f8",
      "old_mode": 33188,
      "old_path": "mojo/edk/system/channel_unittest.cc",
      "new_id": "40ef08131ff2721ba5d7727bec6110b3eb91754b",
      "new_mode": 33188,
      "new_path": "mojo/edk/system/channel_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "c8658a86aec584e72cfe733fa3d7c269da5771c5",
      "old_mode": 33188,
      "old_path": "mojo/edk/system/core.cc",
      "new_id": "e5029c0a37a17bfafe6d815b288d14bcf4ddaa59",
      "new_mode": 33188,
      "new_path": "mojo/edk/system/core.cc"
    },
    {
      "type": "modify",
      "old_id": "f56f3fd66803cb409081fba129204ba051fca951",
      "old_mode": 33188,
      "old_path": "mojo/edk/system/core_test_base.cc",
      "new_id": "30ae304347f913796aed8edd4d17fa77f28fa181",
      "new_mode": 33188,
      "new_path": "mojo/edk/system/core_test_base.cc"
    },
    {
      "type": "modify",
      "old_id": "4bdaa6e2cd915a4e889d7f46003b5d915ddcb550",
      "old_mode": 33188,
      "old_path": "mojo/edk/system/core_test_base.h",
      "new_id": "b828e768f5f3f4c0b5fa22a8edb8afe6c6f99a50",
      "new_mode": 33188,
      "new_path": "mojo/edk/system/core_test_base.h"
    },
    {
      "type": "modify",
      "old_id": "06e1840bc1ee14a00852ee805f10a2d492d41247",
      "old_mode": 33188,
      "old_path": "mojo/edk/system/data_pipe.cc",
      "new_id": "42c4d6e7ad002b8521475fb8b218d73010a7647c",
      "new_mode": 33188,
      "new_path": "mojo/edk/system/data_pipe.cc"
    },
    {
      "type": "modify",
      "old_id": "5afa4567309b8b7143d4f4d4f4b5a96b437cb3fb",
      "old_mode": 33188,
      "old_path": "mojo/edk/system/data_pipe.h",
      "new_id": "78fa471df67e4634d9775a885666b44faeb2e8f1",
      "new_mode": 33188,
      "new_path": "mojo/edk/system/data_pipe.h"
    },
    {
      "type": "modify",
      "old_id": "eb93a0452bbd0e89d654e6e5ad29842125954c74",
      "old_mode": 33188,
      "old_path": "mojo/edk/system/data_pipe_consumer_dispatcher.cc",
      "new_id": "e7bf2f6d4fa3aa55f0ca490cffd0bb0c657cd2d7",
      "new_mode": 33188,
      "new_path": "mojo/edk/system/data_pipe_consumer_dispatcher.cc"
    },
    {
      "type": "modify",
      "old_id": "c8977f3160c2db93477bf033d32ed70f26a17764",
      "old_mode": 33188,
      "old_path": "mojo/edk/system/data_pipe_consumer_dispatcher.h",
      "new_id": "de0a6a36faa3e1e5344858d125aa53527872a645",
      "new_mode": 33188,
      "new_path": "mojo/edk/system/data_pipe_consumer_dispatcher.h"
    },
    {
      "type": "modify",
      "old_id": "a7105c07f0ee52ac4493081a15397f081b3cf1cb",
      "old_mode": 33188,
      "old_path": "mojo/edk/system/data_pipe_impl_unittest.cc",
      "new_id": "3f783badd4219325fe2baae00a3ae585618dadd3",
      "new_mode": 33188,
      "new_path": "mojo/edk/system/data_pipe_impl_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "c9c686a140fa3e7bdb2d9e83829bcd37493ec881",
      "old_mode": 33188,
      "old_path": "mojo/edk/system/data_pipe_producer_dispatcher.cc",
      "new_id": "c6696cd616557dcbfad913392d3824428a590912",
      "new_mode": 33188,
      "new_path": "mojo/edk/system/data_pipe_producer_dispatcher.cc"
    },
    {
      "type": "modify",
      "old_id": "0f72e7f73c22c1766907aceaf25260cb43f94ec1",
      "old_mode": 33188,
      "old_path": "mojo/edk/system/data_pipe_producer_dispatcher.h",
      "new_id": "f2e942686fe8b544f1e3923403e7cfca86e514e6",
      "new_mode": 33188,
      "new_path": "mojo/edk/system/data_pipe_producer_dispatcher.h"
    },
    {
      "type": "modify",
      "old_id": "2c9ade3c3a341622040e31d986eb63fe52ca93d0",
      "old_mode": 33188,
      "old_path": "mojo/edk/system/dispatcher.cc",
      "new_id": "02304bd64d53a03d7ebd13be9101a989d0725a22",
      "new_mode": 33188,
      "new_path": "mojo/edk/system/dispatcher.cc"
    },
    {
      "type": "modify",
      "old_id": "0646f7bef997dae5d7b9b084e9f9cbe54f17c1e9",
      "old_mode": 33188,
      "old_path": "mojo/edk/system/dispatcher.h",
      "new_id": "ea7596c4e6801ced82026ce5d94b2671f0ae9f8b",
      "new_mode": 33188,
      "new_path": "mojo/edk/system/dispatcher.h"
    },
    {
      "type": "modify",
      "old_id": "033c1601947f8c6929114b79411636c4d8fc37b8",
      "old_mode": 33188,
      "old_path": "mojo/edk/system/dispatcher_unittest.cc",
      "new_id": "f4aaf052318d4454059f84fd9470a531ae0883e8",
      "new_mode": 33188,
      "new_path": "mojo/edk/system/dispatcher_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "f271c715db2f9ffa2feb3850bf2983574eb773d1",
      "old_mode": 33188,
      "old_path": "mojo/edk/system/ipc_support_unittest.cc",
      "new_id": "676a8ee59649ef08e241ec1c718e732dfd7a453b",
      "new_mode": 33188,
      "new_path": "mojo/edk/system/ipc_support_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "5d728422bad47157d7fa2cc4486b94bc7f8d3d60",
      "old_mode": 33188,
      "old_path": "mojo/edk/system/local_message_pipe_endpoint.cc",
      "new_id": "af5915593807ba3195b266a71fd7f2f2d14d9058",
      "new_mode": 33188,
      "new_path": "mojo/edk/system/local_message_pipe_endpoint.cc"
    },
    {
      "type": "modify",
      "old_id": "7e9904c35a01873384afb9dffa281f95d9432318",
      "old_mode": 33188,
      "old_path": "mojo/edk/system/local_message_pipe_endpoint.h",
      "new_id": "dc2aeeb8c1d7c53d50223123394d1f7c66e2c4d1",
      "new_mode": 33188,
      "new_path": "mojo/edk/system/local_message_pipe_endpoint.h"
    },
    {
      "type": "modify",
      "old_id": "74b73a7949350f6329d824b17285fec3bbbc2b29",
      "old_mode": 33188,
      "old_path": "mojo/edk/system/message_pipe.cc",
      "new_id": "9de43d63e4c42678659f1621254f5ebdf2324fbc",
      "new_mode": 33188,
      "new_path": "mojo/edk/system/message_pipe.cc"
    },
    {
      "type": "modify",
      "old_id": "c5a684dde92028284ba71b15671d97dc818e3842",
      "old_mode": 33188,
      "old_path": "mojo/edk/system/message_pipe.h",
      "new_id": "547d83af9388cf6b607ffd1d0441e681122b116f",
      "new_mode": 33188,
      "new_path": "mojo/edk/system/message_pipe.h"
    },
    {
      "type": "modify",
      "old_id": "e16548e0b1b99925199ea4fe09a0e13b14d3bb08",
      "old_mode": 33188,
      "old_path": "mojo/edk/system/message_pipe_dispatcher.cc",
      "new_id": "8c7994c69e37d57fea6c71475adf0874c955a8c2",
      "new_mode": 33188,
      "new_path": "mojo/edk/system/message_pipe_dispatcher.cc"
    },
    {
      "type": "modify",
      "old_id": "a7360a6da6b9f32af3b2769ff55ccf7c1eb37a5b",
      "old_mode": 33188,
      "old_path": "mojo/edk/system/message_pipe_dispatcher.h",
      "new_id": "4f5c543b1894b090c0bef841a2ccdbf59ac43e2f",
      "new_mode": 33188,
      "new_path": "mojo/edk/system/message_pipe_dispatcher.h"
    },
    {
      "type": "modify",
      "old_id": "69b14b825a4193a05b7bae88b438f00d036a8c01",
      "old_mode": 33188,
      "old_path": "mojo/edk/system/message_pipe_dispatcher_unittest.cc",
      "new_id": "667ca40a3581b488f37efeb994e84b6f440cd086",
      "new_mode": 33188,
      "new_path": "mojo/edk/system/message_pipe_dispatcher_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "0211f8695adfe76edfa060eb50b1f6011bbd8725",
      "old_mode": 33188,
      "old_path": "mojo/edk/system/message_pipe_endpoint.cc",
      "new_id": "42da701e92bb2984ac5a874ff624f932e11dea96",
      "new_mode": 33188,
      "new_path": "mojo/edk/system/message_pipe_endpoint.cc"
    },
    {
      "type": "modify",
      "old_id": "9c1d546e9acff8f2de9edbc5e8b5260661b38e01",
      "old_mode": 33188,
      "old_path": "mojo/edk/system/message_pipe_endpoint.h",
      "new_id": "ab12d89a37f56e77c0ac1e2af5a3950f2c318e99",
      "new_mode": 33188,
      "new_path": "mojo/edk/system/message_pipe_endpoint.h"
    },
    {
      "type": "modify",
      "old_id": "25c6dfe25e1ca0327a70418cd0821b26c2c8a4fc",
      "old_mode": 33188,
      "old_path": "mojo/edk/system/message_pipe_test_utils.cc",
      "new_id": "5ecef0b40f3cf6449bada7d32b848ccccb8c8085",
      "new_mode": 33188,
      "new_path": "mojo/edk/system/message_pipe_test_utils.cc"
    },
    {
      "type": "modify",
      "old_id": "28beda8e276bd0a4c177eec6d935c8be312e3f60",
      "old_mode": 33188,
      "old_path": "mojo/edk/system/message_pipe_unittest.cc",
      "new_id": "29f75123b60189c875d2354cde5a4db9654e8967",
      "new_mode": 33188,
      "new_path": "mojo/edk/system/message_pipe_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "624de09ca1064cd90ba6aef8948de3eac1d9121c",
      "old_mode": 33188,
      "old_path": "mojo/edk/system/remote_data_pipe_impl_unittest.cc",
      "new_id": "7bae3d29ff76a10140610e6ab3cbeb01194fd993",
      "new_mode": 33188,
      "new_path": "mojo/edk/system/remote_data_pipe_impl_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "326ab1f53065fe1abc3c16ff96a147a6947e7cc5",
      "old_mode": 33188,
      "old_path": "mojo/edk/system/remote_message_pipe_unittest.cc",
      "new_id": "5c4d662100864b7e17e9dfa6f736cbb5c0f51f3d",
      "new_mode": 33188,
      "new_path": "mojo/edk/system/remote_message_pipe_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "0050133e8ca5e837e50a6865d7a2ec8f0d80b13f",
      "old_mode": 33188,
      "old_path": "mojo/edk/system/simple_dispatcher.cc",
      "new_id": "25ae5ff04e0861e2b621f8edcef903b862cbb063",
      "new_mode": 33188,
      "new_path": "mojo/edk/system/simple_dispatcher.cc"
    },
    {
      "type": "modify",
      "old_id": "95942cfa0f6c1e8903f711b85a705232f67a4104",
      "old_mode": 33188,
      "old_path": "mojo/edk/system/simple_dispatcher.h",
      "new_id": "eecbf40576d19fe82220b7bb2bec7b00f5df3f1c",
      "new_mode": 33188,
      "new_path": "mojo/edk/system/simple_dispatcher.h"
    },
    {
      "type": "modify",
      "old_id": "c03dfa5772276051ff23e57d13664600c1641bff",
      "old_mode": 33188,
      "old_path": "mojo/edk/system/simple_dispatcher_unittest.cc",
      "new_id": "9f92be7f9e8cc1eeaf96c3ad76b8c7304e605738",
      "new_mode": 33188,
      "new_path": "mojo/edk/system/simple_dispatcher_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "7525a21ddbfe7f7148e072d0fa5aee44dc09ce5c",
      "old_mode": 33188,
      "old_path": "mojo/edk/system/wait_set_dispatcher.cc",
      "new_id": "4b5c7da0fa79389d3d48bedabac8fdc573fb7bb1",
      "new_mode": 33188,
      "new_path": "mojo/edk/system/wait_set_dispatcher.cc"
    },
    {
      "type": "modify",
      "old_id": "b2423ab40de58959012a8c5697a359e1a0a5f746",
      "old_mode": 33188,
      "old_path": "mojo/edk/system/waiter_test_utils.cc",
      "new_id": "c261be8cfdef5bc19582a4c81c52fd27b4965a97",
      "new_mode": 33188,
      "new_path": "mojo/edk/system/waiter_test_utils.cc"
    }
  ]
}