ApplicationConnection devolution, part 4 (the end). Nuke ApplicationConnection and ServiceRegistry. Also clean up includes. R=vardhan@google.com Review URL: https://codereview.chromium.org/1977023003 .
diff --git a/examples/apptest/example_service_application.cc b/examples/apptest/example_service_application.cc index 1e9a297..f358173 100644 --- a/examples/apptest/example_service_application.cc +++ b/examples/apptest/example_service_application.cc
@@ -7,8 +7,8 @@ #include <memory> #include "mojo/public/c/system/main.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_runner.h" +#include "mojo/public/cpp/application/service_provider_impl.h" namespace mojo {
diff --git a/examples/bank_app/bank.cc b/examples/bank_app/bank.cc index 9e14044..4f96ecd 100644 --- a/examples/bank_app/bank.cc +++ b/examples/bank_app/bank.cc
@@ -7,11 +7,11 @@ #include "examples/bank_app/bank.mojom.h" #include "mojo/common/binding_set.h" #include "mojo/public/c/system/main.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_delegate.h" #include "mojo/public/cpp/application/application_impl.h" #include "mojo/public/cpp/application/application_runner.h" #include "mojo/public/cpp/application/connect.h" +#include "mojo/public/cpp/application/service_provider_impl.h" #include "mojo/public/cpp/bindings/strong_binding.h" #include "mojo/public/cpp/utility/run_loop.h" #include "mojo/services/vanadium/security/interfaces/principal.mojom.h"
diff --git a/examples/echo/echo_server.cc b/examples/echo/echo_server.cc index aa82a20..a920bdb 100644 --- a/examples/echo/echo_server.cc +++ b/examples/echo/echo_server.cc
@@ -7,9 +7,9 @@ #include "examples/echo/echo.mojom.h" #include "mojo/common/binding_set.h" #include "mojo/public/c/system/main.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_delegate.h" #include "mojo/public/cpp/application/application_runner.h" +#include "mojo/public/cpp/application/service_provider_impl.h" #include "mojo/public/cpp/bindings/strong_binding.h" namespace mojo {
diff --git a/examples/echo_terminal/main.cc b/examples/echo_terminal/main.cc index 24be650..6c56eaf 100644 --- a/examples/echo_terminal/main.cc +++ b/examples/echo_terminal/main.cc
@@ -11,8 +11,8 @@ #include "mojo/application/application_runner_chromium.h" #include "mojo/common/binding_set.h" #include "mojo/public/c/system/main.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_delegate.h" +#include "mojo/public/cpp/application/service_provider_impl.h" #include "mojo/services/files/interfaces/file.mojom.h" #include "mojo/services/files/interfaces/types.mojom.h" #include "mojo/services/terminal/interfaces/terminal_client.mojom.h"
diff --git a/examples/forwarding_content_handler/forwarding_content_handler.cc b/examples/forwarding_content_handler/forwarding_content_handler.cc index cc6ff78..91e9d35 100644 --- a/examples/forwarding_content_handler/forwarding_content_handler.cc +++ b/examples/forwarding_content_handler/forwarding_content_handler.cc
@@ -10,8 +10,8 @@ #include "mojo/application/content_handler_factory.h" #include "mojo/data_pipe_utils/data_pipe_utils.h" #include "mojo/public/c/system/main.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_delegate.h" +#include "mojo/public/cpp/application/service_provider_impl.h" #include "mojo/public/cpp/bindings/binding.h" #include "mojo/public/cpp/utility/run_loop.h" #include "mojo/public/interfaces/application/application.mojom.h"
diff --git a/examples/hello_mojo/hello_mojo_server.cc b/examples/hello_mojo/hello_mojo_server.cc index 7e48dec..6ad9a52 100644 --- a/examples/hello_mojo/hello_mojo_server.cc +++ b/examples/hello_mojo/hello_mojo_server.cc
@@ -8,9 +8,9 @@ #include "examples/hello_mojo/hello_mojo.mojom.h" #include "mojo/public/c/system/main.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_delegate.h" #include "mojo/public/cpp/application/application_runner.h" +#include "mojo/public/cpp/application/service_provider_impl.h" #include "mojo/public/cpp/bindings/interface_request.h" #include "mojo/public/cpp/bindings/strong_binding.h" #include "mojo/public/cpp/system/macros.h"
diff --git a/examples/indirect_service/indirect_integer_service.cc b/examples/indirect_service/indirect_integer_service.cc index ec7f589..6d9425c 100644 --- a/examples/indirect_service/indirect_integer_service.cc +++ b/examples/indirect_service/indirect_integer_service.cc
@@ -6,9 +6,9 @@ #include "examples/indirect_service/indirect_service_demo.mojom.h" #include "mojo/public/c/system/main.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_delegate.h" #include "mojo/public/cpp/application/application_runner.h" +#include "mojo/public/cpp/application/service_provider_impl.h" #include "mojo/public/cpp/bindings/binding.h" #include "mojo/public/cpp/bindings/strong_binding.h"
diff --git a/examples/indirect_service/integer_service.cc b/examples/indirect_service/integer_service.cc index e7979f9..dac2703 100644 --- a/examples/indirect_service/integer_service.cc +++ b/examples/indirect_service/integer_service.cc
@@ -6,9 +6,9 @@ #include "examples/indirect_service/indirect_service_demo.mojom.h" #include "mojo/public/c/system/main.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_delegate.h" #include "mojo/public/cpp/application/application_runner.h" +#include "mojo/public/cpp/application/service_provider_impl.h" #include "mojo/public/cpp/bindings/strong_binding.h" namespace mojo {
diff --git a/examples/media_test/media_test_app.cc b/examples/media_test/media_test_app.cc index dc618f3..0c42f22 100644 --- a/examples/media_test/media_test_app.cc +++ b/examples/media_test/media_test_app.cc
@@ -11,7 +11,6 @@ #include "examples/media_test/media_test.h" #include "mojo/application/application_runner_chromium.h" #include "mojo/public/c/system/main.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_delegate.h" #include "mojo/public/cpp/application/application_impl.h"
diff --git a/examples/moterm_example_app/moterm_example_app.cc b/examples/moterm_example_app/moterm_example_app.cc index 93ec4cf..81e6984 100644 --- a/examples/moterm_example_app/moterm_example_app.cc +++ b/examples/moterm_example_app/moterm_example_app.cc
@@ -18,7 +18,6 @@ #include "mojo/application/application_runner_chromium.h" #include "mojo/common/binding_set.h" #include "mojo/public/c/system/main.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_delegate.h" #include "mojo/public/cpp/application/application_impl.h" #include "mojo/public/cpp/application/connect.h"
diff --git a/examples/native_run_app/native_run_app.cc b/examples/native_run_app/native_run_app.cc index 5e36ad4..1841ed8 100644 --- a/examples/native_run_app/native_run_app.cc +++ b/examples/native_run_app/native_run_app.cc
@@ -24,10 +24,10 @@ #include "base/strings/string_split.h" #include "mojo/application/application_runner_chromium.h" #include "mojo/public/c/system/main.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_delegate.h" #include "mojo/public/cpp/application/application_impl.h" #include "mojo/public/cpp/application/connect.h" +#include "mojo/public/cpp/application/service_provider_impl.h" #include "mojo/public/cpp/bindings/interface_request.h" #include "mojo/public/cpp/bindings/strong_binding.h" #include "mojo/services/files/interfaces/files.mojom.h"
diff --git a/examples/recursive_content_handler/recursive_content_handler.cc b/examples/recursive_content_handler/recursive_content_handler.cc index 4ee0178..62f9357 100644 --- a/examples/recursive_content_handler/recursive_content_handler.cc +++ b/examples/recursive_content_handler/recursive_content_handler.cc
@@ -7,9 +7,9 @@ #include "mojo/application/application_runner_chromium.h" #include "mojo/application/content_handler_factory.h" #include "mojo/public/c/system/main.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_delegate.h" #include "mojo/public/cpp/application/application_impl.h" +#include "mojo/public/cpp/application/service_provider_impl.h" #include "mojo/services/content_handler/interfaces/content_handler.mojom.h" namespace mojo {
diff --git a/examples/spinning_cube/spinning_cube_app.cc b/examples/spinning_cube/spinning_cube_app.cc index f7c6c1f..694c66a 100644 --- a/examples/spinning_cube/spinning_cube_app.cc +++ b/examples/spinning_cube/spinning_cube_app.cc
@@ -10,11 +10,11 @@ #include "base/bind.h" #include "examples/spinning_cube/gles2_client_impl.h" #include "mojo/public/c/system/main.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_delegate.h" #include "mojo/public/cpp/application/application_impl.h" #include "mojo/public/cpp/application/application_runner.h" #include "mojo/public/cpp/application/connect.h" +#include "mojo/public/cpp/application/service_provider_impl.h" #include "mojo/public/cpp/system/macros.h" #include "mojo/public/cpp/utility/run_loop.h" #include "mojo/services/native_viewport/interfaces/native_viewport.mojom.h"
diff --git a/examples/trace_me/trace_me_app.cc b/examples/trace_me/trace_me_app.cc index 0f627ae..b33ccc5 100644 --- a/examples/trace_me/trace_me_app.cc +++ b/examples/trace_me/trace_me_app.cc
@@ -11,10 +11,10 @@ #include "mojo/application/application_runner_chromium.h" #include "mojo/common/tracing_impl.h" #include "mojo/public/c/system/main.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_delegate.h" #include "mojo/public/cpp/application/application_impl.h" #include "mojo/public/cpp/application/application_runner.h" +#include "mojo/public/cpp/application/service_provider_impl.h" // This is an example app that uses implementation of tracing from mojo/common // to participate in the tracing ecosystem.
diff --git a/mojo/application/content_handler_factory.cc b/mojo/application/content_handler_factory.cc index b3c7a26..8b10448 100644 --- a/mojo/application/content_handler_factory.cc +++ b/mojo/application/content_handler_factory.cc
@@ -14,7 +14,6 @@ #include "base/trace_event/trace_event.h" #include "mojo/application/application_runner_chromium.h" #include "mojo/message_pump/message_pump_mojo.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_delegate.h" #include "mojo/public/cpp/application/application_impl.h" #include "mojo/public/cpp/bindings/strong_binding.h"
diff --git a/mojo/common/trace_provider_impl.cc b/mojo/common/trace_provider_impl.cc index cda6b61..2139b7c 100644 --- a/mojo/common/trace_provider_impl.cc +++ b/mojo/common/trace_provider_impl.cc
@@ -12,7 +12,6 @@ #include "base/time/time.h" #include "base/trace_event/trace_config.h" #include "base/trace_event/trace_event.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_impl.h" namespace mojo {
diff --git a/mojo/public/cpp/application/BUILD.gn b/mojo/public/cpp/application/BUILD.gn index dda638c..cbf41ac 100644 --- a/mojo/public/cpp/application/BUILD.gn +++ b/mojo/public/cpp/application/BUILD.gn
@@ -7,19 +7,15 @@ # GYP version: mojo/public/mojo_public.gyp:mojo_application_base mojo_sdk_source_set("application") { sources = [ - "application_connection.h", "application_delegate.h", "application_impl.h", "connect.h", "connection_context.h", - "lib/application_connection.cc", "lib/application_delegate.cc", "lib/application_impl.cc", "lib/service_connector_registry.cc", "lib/service_connector_registry.h", "lib/service_provider_impl.cc", - "lib/service_registry.cc", - "lib/service_registry.h", "service_connector.h", "service_provider_impl.h", ]
diff --git a/mojo/public/cpp/application/application_connection.h b/mojo/public/cpp/application/application_connection.h deleted file mode 100644 index e10b7b1..0000000 --- a/mojo/public/cpp/application/application_connection.h +++ /dev/null
@@ -1,27 +0,0 @@ -// Copyright 2014 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#ifndef MOJO_PUBLIC_APPLICATION_APPLICATION_CONNECTION_H_ -#define MOJO_PUBLIC_APPLICATION_APPLICATION_CONNECTION_H_ - -#include "mojo/public/cpp/application/service_provider_impl.h" - -namespace mojo { - -// Represents a connection to another application. An instance of this class is -// passed to ApplicationDelegate's ConfigureIncomingConnection() method each -// time a connection is made to this app, and is returned by the -// ApplicationDelegate's ConnectToApplication() method when this app -// connects to another. -// TODO(vtl): Don't get too attached to this class. I'm going to remove it. -class ApplicationConnection { - public: - virtual ~ApplicationConnection(); - - virtual ServiceProviderImpl& GetServiceProviderImpl() = 0; -}; - -} // namespace mojo - -#endif // MOJO_PUBLIC_APPLICATION_APPLICATION_CONNECTION_H_
diff --git a/mojo/public/cpp/application/application_impl.h b/mojo/public/cpp/application/application_impl.h index b4038dc..dd613f1 100644 --- a/mojo/public/cpp/application/application_impl.h +++ b/mojo/public/cpp/application/application_impl.h
@@ -10,7 +10,6 @@ #include <vector> #include "mojo/public/cpp/application/application_delegate.h" -#include "mojo/public/cpp/application/lib/service_registry.h" #include "mojo/public/cpp/system/macros.h" #include "mojo/public/interfaces/application/application.mojom.h" #include "mojo/public/interfaces/application/application_connector.mojom.h" @@ -18,6 +17,8 @@ namespace mojo { +class ServiceProviderImpl; + // Implements the Application interface, which the shell uses for basic // communication with an application (e.g., to connect clients to services // provided by an application). Also provides the application access to the @@ -81,9 +82,7 @@ void RequestQuit() override; private: - using ServiceRegistryList = - std::vector<std::unique_ptr<internal::ServiceRegistry>>; - ServiceRegistryList incoming_service_registries_; + std::vector<std::unique_ptr<ServiceProviderImpl>> service_provider_impls_; ApplicationDelegate* delegate_; Binding<Application> binding_; ShellPtr shell_;
diff --git a/mojo/public/cpp/application/lib/application_connection.cc b/mojo/public/cpp/application/lib/application_connection.cc deleted file mode 100644 index d557817..0000000 --- a/mojo/public/cpp/application/lib/application_connection.cc +++ /dev/null
@@ -1,12 +0,0 @@ -// Copyright 2014 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#include "mojo/public/cpp/application/application_connection.h" - -namespace mojo { - -ApplicationConnection::~ApplicationConnection() { -} - -} // namespace mojo
diff --git a/mojo/public/cpp/application/lib/application_impl.cc b/mojo/public/cpp/application/lib/application_impl.cc index 0ad3a3f..c87344b 100644 --- a/mojo/public/cpp/application/lib/application_impl.cc +++ b/mojo/public/cpp/application/lib/application_impl.cc
@@ -8,7 +8,7 @@ #include "mojo/public/cpp/application/application_delegate.h" #include "mojo/public/cpp/application/connection_context.h" -#include "mojo/public/cpp/application/lib/service_registry.h" +#include "mojo/public/cpp/application/service_provider_impl.h" #include "mojo/public/cpp/bindings/interface_ptr.h" #include "mojo/public/cpp/bindings/interface_request.h" #include "mojo/public/cpp/environment/logging.h" @@ -52,7 +52,7 @@ shell_ = ShellPtr::Create(std::move(shell)); shell_.set_connection_error_handler([this]() { delegate_->Quit(); - incoming_service_registries_.clear(); + service_provider_impls_.clear(); Terminate(); }); url_ = url; @@ -70,15 +70,14 @@ // drop it on the floor. MOJO_LOG_IF(ERROR, exposed_services) << "DEPRECATED: exposed_services is going away"; - std::unique_ptr<internal::ServiceRegistry> registry( - new internal::ServiceRegistry( + std::unique_ptr<ServiceProviderImpl> service_provider_impl( + new ServiceProviderImpl( ConnectionContext(ConnectionContext::Type::INCOMING, requestor_url, url), services.Pass())); - if (!delegate_->ConfigureIncomingConnection( - ®istry->GetServiceProviderImpl())) + if (!delegate_->ConfigureIncomingConnection(service_provider_impl.get())) return; - incoming_service_registries_.push_back(std::move(registry)); + service_provider_impls_.push_back(std::move(service_provider_impl)); } void ApplicationImpl::RequestQuit() {
diff --git a/mojo/public/cpp/application/lib/service_connector_registry.cc b/mojo/public/cpp/application/lib/service_connector_registry.cc index 6a974de..2698b71 100644 --- a/mojo/public/cpp/application/lib/service_connector_registry.cc +++ b/mojo/public/cpp/application/lib/service_connector_registry.cc
@@ -6,7 +6,6 @@ #include <utility> -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/connection_context.h" #include "mojo/public/cpp/application/service_connector.h"
diff --git a/mojo/public/cpp/application/lib/service_registry.cc b/mojo/public/cpp/application/lib/service_registry.cc deleted file mode 100644 index b36b63b..0000000 --- a/mojo/public/cpp/application/lib/service_registry.cc +++ /dev/null
@@ -1,32 +0,0 @@ -// Copyright 2014 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#include "mojo/public/cpp/application/lib/service_registry.h" - -#include "mojo/public/cpp/application/application_connection.h" -#include "mojo/public/cpp/application/service_connector.h" - -namespace mojo { -namespace internal { - -ServiceRegistry::ServiceRegistry() {} - -ServiceRegistry::ServiceRegistry( - const ConnectionContext& connection_context, - InterfaceRequest<ServiceProvider> local_services) - : service_provider_impl_(connection_context, local_services.Pass()) {} - -ServiceRegistry::~ServiceRegistry() {} - -void ServiceRegistry::RemoveServiceConnectorForName( - const std::string& interface_name) { - service_provider_impl_.RemoveServiceForName(interface_name); -} - -ServiceProviderImpl& ServiceRegistry::GetServiceProviderImpl() { - return service_provider_impl_; -} - -} // namespace internal -} // namespace mojo
diff --git a/mojo/public/cpp/application/lib/service_registry.h b/mojo/public/cpp/application/lib/service_registry.h deleted file mode 100644 index 0e2789d..0000000 --- a/mojo/public/cpp/application/lib/service_registry.h +++ /dev/null
@@ -1,40 +0,0 @@ -// Copyright 2014 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#ifndef MOJO_PUBLIC_CPP_APPLICATION_LIB_SERVICE_REGISTRY_H_ -#define MOJO_PUBLIC_CPP_APPLICATION_LIB_SERVICE_REGISTRY_H_ - -#include <string> - -#include "mojo/public/cpp/application/application_connection.h" -#include "mojo/public/cpp/application/service_provider_impl.h" - -namespace mojo { -namespace internal { - -// A ServiceRegistry represents each half of a connection between two -// applications, allowing customization of which services are published to the -// other. -class ServiceRegistry : public ApplicationConnection { - public: - ServiceRegistry(); - ServiceRegistry(const ConnectionContext& connection_context, - InterfaceRequest<ServiceProvider> local_services); - ~ServiceRegistry() override; - - // ApplicationConnection overrides. - ServiceProviderImpl& GetServiceProviderImpl() override; - - void RemoveServiceConnectorForName(const std::string& interface_name); - - private: - ServiceProviderImpl service_provider_impl_; - - MOJO_DISALLOW_COPY_AND_ASSIGN(ServiceRegistry); -}; - -} // namespace internal -} // namespace mojo - -#endif // MOJO_PUBLIC_CPP_APPLICATION_LIB_SERVICE_REGISTRY_H_
diff --git a/mojo/public/cpp/bindings/tests/versioning_test_service.cc b/mojo/public/cpp/bindings/tests/versioning_test_service.cc index 3474dd9..cba93f9 100644 --- a/mojo/public/cpp/bindings/tests/versioning_test_service.cc +++ b/mojo/public/cpp/bindings/tests/versioning_test_service.cc
@@ -6,9 +6,9 @@ #include <memory> #include "mojo/public/c/system/main.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_delegate.h" #include "mojo/public/cpp/application/application_runner.h" +#include "mojo/public/cpp/application/service_provider_impl.h" #include "mojo/public/cpp/bindings/strong_binding.h" #include "mojo/public/cpp/system/macros.h" #include "mojo/public/interfaces/bindings/tests/versioning_test_service.mojom.h"
diff --git a/mojo/ui/view_provider_app.h b/mojo/ui/view_provider_app.h index 41c32f8..177f419 100644 --- a/mojo/ui/view_provider_app.h +++ b/mojo/ui/view_provider_app.h
@@ -9,8 +9,8 @@ #include "mojo/common/strong_binding_set.h" #include "mojo/public/c/system/main.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_impl.h" +#include "mojo/public/cpp/application/service_provider_impl.h" #include "mojo/public/cpp/system/macros.h" #include "mojo/services/ui/views/interfaces/view_provider.mojom.h"
diff --git a/services/asset_bundle/main.cc b/services/asset_bundle/main.cc index 1896263..fc3fdf7 100644 --- a/services/asset_bundle/main.cc +++ b/services/asset_bundle/main.cc
@@ -6,8 +6,8 @@ #include "base/threading/sequenced_worker_pool.h" #include "mojo/application/application_runner_chromium.h" #include "mojo/public/c/system/main.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_delegate.h" +#include "mojo/public/cpp/application/service_provider_impl.h" #include "services/asset_bundle/asset_unpacker_impl.h" namespace mojo {
diff --git a/services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_app.h b/services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_app.h index a8eadef..8af5c34 100644 --- a/services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_app.h +++ b/services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_app.h
@@ -6,8 +6,8 @@ #define SERVICES_AUTHENTICATING_URL_LOADER_INTERCEPTOR_AUTHENTICATING_URL_LOADER_INTERCEPTOR_APP_H_ #include "base/macros.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_delegate.h" +#include "mojo/public/cpp/application/service_provider_impl.h" #include "mojo/services/authenticating_url_loader_interceptor/interfaces/authenticating_url_loader_interceptor_meta_factory.mojom.h" #include "services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_meta_factory_impl.h"
diff --git a/services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_apptest.cc b/services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_apptest.cc index e98a4d3..b04cc90 100644 --- a/services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_apptest.cc +++ b/services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_apptest.cc
@@ -9,7 +9,6 @@ #include "base/run_loop.h" #include "base/strings/string_split.h" #include "base/strings/stringprintf.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_impl.h" #include "mojo/public/cpp/application/application_test_base.h" #include "mojo/public/cpp/application/connect.h"
diff --git a/services/authentication/main.cc b/services/authentication/main.cc index ff23499..dd77d35 100644 --- a/services/authentication/main.cc +++ b/services/authentication/main.cc
@@ -5,10 +5,10 @@ #include "mojo/application/application_runner_chromium.h" #include "mojo/common/binding_set.h" #include "mojo/public/c/system/main.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_delegate.h" #include "mojo/public/cpp/application/application_impl.h" #include "mojo/public/cpp/application/connect.h" +#include "mojo/public/cpp/application/service_provider_impl.h" #include "mojo/public/cpp/bindings/strong_binding.h" #include "mojo/public/cpp/system/macros.h" #include "mojo/services/authentication/interfaces/authentication.mojom.h"
diff --git a/services/clipboard/main.cc b/services/clipboard/main.cc index 4ddbc31..be8faea 100644 --- a/services/clipboard/main.cc +++ b/services/clipboard/main.cc
@@ -4,8 +4,8 @@ #include "mojo/application/application_runner_chromium.h" #include "mojo/public/c/system/main.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_delegate.h" +#include "mojo/public/cpp/application/service_provider_impl.h" #include "services/clipboard/clipboard_standalone_impl.h" class Delegate : public mojo::ApplicationDelegate {
diff --git a/services/device_info/device_info.cc b/services/device_info/device_info.cc index 01d46b2..749f909 100644 --- a/services/device_info/device_info.cc +++ b/services/device_info/device_info.cc
@@ -7,9 +7,9 @@ #include "mojo/common/binding_set.h" #include "mojo/public/c/system/main.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_delegate.h" #include "mojo/public/cpp/application/application_runner.h" +#include "mojo/public/cpp/application/service_provider_impl.h" #include "mojo/services/device_info/interfaces/device_info.mojom.h" namespace mojo {
diff --git a/services/files/main.cc b/services/files/main.cc index c84b7ec..04f61a9 100644 --- a/services/files/main.cc +++ b/services/files/main.cc
@@ -5,8 +5,8 @@ #include "base/macros.h" #include "mojo/application/application_runner_chromium.h" #include "mojo/public/c/system/main.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_delegate.h" +#include "mojo/public/cpp/application/service_provider_impl.h" #include "mojo/services/files/interfaces/files.mojom.h" #include "services/files/files_impl.h"
diff --git a/services/gfx/compositor/compositor_app.cc b/services/gfx/compositor/compositor_app.cc index 555e4d7..8c28965 100644 --- a/services/gfx/compositor/compositor_app.cc +++ b/services/gfx/compositor/compositor_app.cc
@@ -10,8 +10,8 @@ #include "mojo/application/application_runner_chromium.h" #include "mojo/common/tracing_impl.h" #include "mojo/public/c/system/main.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_impl.h" +#include "mojo/public/cpp/application/service_provider_impl.h" #include "services/gfx/compositor/compositor_impl.h" namespace compositor {
diff --git a/services/icu_data/icu_data_impl.cc b/services/icu_data/icu_data_impl.cc index bd2b65a..c1566f6 100644 --- a/services/icu_data/icu_data_impl.cc +++ b/services/icu_data/icu_data_impl.cc
@@ -5,8 +5,8 @@ #include "mojo/application/application_runner_chromium.h" #include "mojo/common/binding_set.h" #include "mojo/public/c/system/main.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_delegate.h" +#include "mojo/public/cpp/application/service_provider_impl.h" #include "mojo/public/cpp/bindings/interface_ptr.h" #include "mojo/services/icu_data/interfaces/icu_data.mojom.h" #include "services/icu_data/kICUData.h"
diff --git a/services/keyboard/linux/keyboard_service_impl.cc b/services/keyboard/linux/keyboard_service_impl.cc index e9fd9eb..5d41bcd 100644 --- a/services/keyboard/linux/keyboard_service_impl.cc +++ b/services/keyboard/linux/keyboard_service_impl.cc
@@ -7,7 +7,6 @@ #include "base/logging.h" #include "base/strings/string16.h" #include "base/strings/utf_string_conversions.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/connect.h" #include "mojo/services/input_events/interfaces/input_key_codes.mojom.h"
diff --git a/services/keyboard/linux/main.cc b/services/keyboard/linux/main.cc index 19bd0ff..b96e49f 100644 --- a/services/keyboard/linux/main.cc +++ b/services/keyboard/linux/main.cc
@@ -6,10 +6,10 @@ #include "base/threading/sequenced_worker_pool.h" #include "mojo/application/application_runner_chromium.h" #include "mojo/public/c/system/main.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_delegate.h" #include "mojo/public/cpp/application/application_impl.h" #include "mojo/public/cpp/application/connect.h" +#include "mojo/public/cpp/application/service_provider_impl.h" #include "mojo/services/native_viewport/interfaces/native_viewport_event_dispatcher.mojom.h" #include "services/keyboard/linux/keyboard_service_impl.h"
diff --git a/services/log/main.cc b/services/log/main.cc index f9f8610..574e9bb 100644 --- a/services/log/main.cc +++ b/services/log/main.cc
@@ -8,8 +8,8 @@ #include "mojo/application/application_runner_chromium.h" #include "mojo/public/c/system/main.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_delegate.h" +#include "mojo/public/cpp/application/service_provider_impl.h" #include "mojo/public/cpp/system/macros.h" #include "mojo/services/log/interfaces/log.mojom.h" #include "services/log/log_impl.h"
diff --git a/services/nacl/nonsfi/pnacl_compile.cc b/services/nacl/nonsfi/pnacl_compile.cc index 003184a..ab80697 100644 --- a/services/nacl/nonsfi/pnacl_compile.cc +++ b/services/nacl/nonsfi/pnacl_compile.cc
@@ -8,9 +8,9 @@ #include "mojo/nacl/nonsfi/file_util.h" #include "mojo/nacl/nonsfi/nexe_launcher_nonsfi.h" #include "mojo/public/c/system/main.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_delegate.h" #include "mojo/public/cpp/application/application_runner.h" +#include "mojo/public/cpp/application/service_provider_impl.h" #include "mojo/public/cpp/bindings/strong_binding.h" #include "services/nacl/nonsfi/kPnaclTranslatorCompile.h" #include "services/nacl/nonsfi/pnacl_compile.mojom.h"
diff --git a/services/nacl/nonsfi/pnacl_link.cc b/services/nacl/nonsfi/pnacl_link.cc index 7ac97ba..e4c741e 100644 --- a/services/nacl/nonsfi/pnacl_link.cc +++ b/services/nacl/nonsfi/pnacl_link.cc
@@ -8,9 +8,9 @@ #include "mojo/nacl/nonsfi/file_util.h" #include "mojo/nacl/nonsfi/nexe_launcher_nonsfi.h" #include "mojo/public/c/system/main.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_delegate.h" #include "mojo/public/cpp/application/application_runner.h" +#include "mojo/public/cpp/application/service_provider_impl.h" #include "mojo/public/cpp/bindings/strong_binding.h" #include "services/nacl/nonsfi/kLdNexe.h" #include "services/nacl/nonsfi/pnacl_link.mojom.h"
diff --git a/services/nacl/sfi/content_handler_main.cc b/services/nacl/sfi/content_handler_main.cc index 161c9c3..3e0a51b 100644 --- a/services/nacl/sfi/content_handler_main.cc +++ b/services/nacl/sfi/content_handler_main.cc
@@ -12,10 +12,10 @@ #include "mojo/message_pump/message_pump_mojo.h" #include "mojo/nacl/sfi/nacl_bindings/monacl_sel_main.h" #include "mojo/public/c/system/main.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_delegate.h" #include "mojo/public/cpp/application/application_impl.h" #include "mojo/public/cpp/application/connect.h" +#include "mojo/public/cpp/application/service_provider_impl.h" #include "mojo/services/network/interfaces/network_service.mojom.h" #include "mojo/services/network/interfaces/url_loader.mojom.h" #include "native_client/src/public/nacl_desc.h"
diff --git a/services/native_support/main.cc b/services/native_support/main.cc index 98db478..912ebc6 100644 --- a/services/native_support/main.cc +++ b/services/native_support/main.cc
@@ -8,8 +8,8 @@ #include "base/threading/sequenced_worker_pool.h" #include "mojo/application/application_runner_chromium.h" #include "mojo/public/c/system/main.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_delegate.h" +#include "mojo/public/cpp/application/service_provider_impl.h" #include "mojo/services/native_support/interfaces/process.mojom.h" #include "services/native_support/process_impl.h"
diff --git a/services/prediction/prediction_service_impl.cc b/services/prediction/prediction_service_impl.cc index 4c53f67..42bf597 100644 --- a/services/prediction/prediction_service_impl.cc +++ b/services/prediction/prediction_service_impl.cc
@@ -6,7 +6,7 @@ #include "mojo/application/application_runner_chromium.h" #include "mojo/public/c/system/main.h" -#include "mojo/public/cpp/application/application_connection.h" +#include "mojo/public/cpp/application/service_provider_impl.h" namespace prediction {
diff --git a/services/test_service/test_request_tracker_application.cc b/services/test_service/test_request_tracker_application.cc index c822601..1877708 100644 --- a/services/test_service/test_request_tracker_application.cc +++ b/services/test_service/test_request_tracker_application.cc
@@ -7,8 +7,8 @@ #include <memory> #include "mojo/public/c/system/main.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_runner.h" +#include "mojo/public/cpp/application/service_provider_impl.h" #include "services/test_service/test_time_service_impl.h" namespace mojo {
diff --git a/services/test_service/test_service_application.cc b/services/test_service/test_service_application.cc index 0c65da4..d458d09 100644 --- a/services/test_service/test_service_application.cc +++ b/services/test_service/test_service_application.cc
@@ -9,8 +9,8 @@ #include <memory> #include "mojo/public/c/system/main.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_runner.h" +#include "mojo/public/cpp/application/service_provider_impl.h" #include "mojo/public/cpp/utility/run_loop.h" #include "services/test_service/test_service_impl.h" #include "services/test_service/test_time_service_impl.h"
diff --git a/services/ui/input_manager/input_manager_app.cc b/services/ui/input_manager/input_manager_app.cc index 5c48355..4d47940 100644 --- a/services/ui/input_manager/input_manager_app.cc +++ b/services/ui/input_manager/input_manager_app.cc
@@ -10,8 +10,8 @@ #include "mojo/application/application_runner_chromium.h" #include "mojo/common/tracing_impl.h" #include "mojo/public/c/system/main.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_impl.h" +#include "mojo/public/cpp/application/service_provider_impl.h" #include "services/ui/input_manager/input_associate.h" namespace input_manager {
diff --git a/services/ui/launcher/launch_instance.cc b/services/ui/launcher/launch_instance.cc index 47a7089..c2aa2cb 100644 --- a/services/ui/launcher/launch_instance.cc +++ b/services/ui/launcher/launch_instance.cc
@@ -9,7 +9,6 @@ #include "base/trace_event/trace_event.h" #include "mojo/application/application_runner_chromium.h" #include "mojo/public/c/system/main.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_impl.h" #include "mojo/public/cpp/application/connect.h" #include "mojo/services/ui/views/interfaces/view_provider.mojom.h"
diff --git a/services/ui/launcher/launcher_app.cc b/services/ui/launcher/launcher_app.cc index 31c16b2..cc140a7 100644 --- a/services/ui/launcher/launcher_app.cc +++ b/services/ui/launcher/launcher_app.cc
@@ -10,8 +10,8 @@ #include "mojo/application/application_runner_chromium.h" #include "mojo/common/tracing_impl.h" #include "mojo/public/c/system/main.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_impl.h" +#include "mojo/public/cpp/application/service_provider_impl.h" namespace launcher {
diff --git a/services/ui/view_manager/view_manager_app.cc b/services/ui/view_manager/view_manager_app.cc index f7c7136..171d8bc 100644 --- a/services/ui/view_manager/view_manager_app.cc +++ b/services/ui/view_manager/view_manager_app.cc
@@ -13,9 +13,9 @@ #include "mojo/application/application_runner_chromium.h" #include "mojo/common/tracing_impl.h" #include "mojo/public/c/system/main.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_impl.h" #include "mojo/public/cpp/application/connect.h" +#include "mojo/public/cpp/application/service_provider_impl.h" #include "services/ui/view_manager/view_manager_impl.h" namespace view_manager {
diff --git a/services/url_response_disk_cache/url_response_disk_cache_app.h b/services/url_response_disk_cache/url_response_disk_cache_app.h index e6fb4c4..e95b6fa 100644 --- a/services/url_response_disk_cache/url_response_disk_cache_app.h +++ b/services/url_response_disk_cache/url_response_disk_cache_app.h
@@ -9,7 +9,6 @@ #include "base/memory/ref_counted.h" #include "base/task_runner.h" #include "base/threading/sequenced_worker_pool.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_delegate.h" #include "mojo/public/cpp/application/application_impl.h" #include "mojo/services/url_response_disk_cache/interfaces/url_response_disk_cache.mojom.h"
diff --git a/services/url_response_disk_cache/url_response_disk_cache_impl.cc b/services/url_response_disk_cache/url_response_disk_cache_impl.cc index 318a469..884ec6f 100644 --- a/services/url_response_disk_cache/url_response_disk_cache_impl.cc +++ b/services/url_response_disk_cache/url_response_disk_cache_impl.cc
@@ -22,7 +22,6 @@ #include "base/trace_event/trace_event.h" #include "crypto/random.h" #include "mojo/data_pipe_utils/data_pipe_utils.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/bindings/lib/fixed_buffer.h" #include "mojo/public/interfaces/network/http_header.mojom.h" #include "services/url_response_disk_cache/url_response_disk_cache_entry.mojom.h"
diff --git a/shell/application_manager/application_manager_unittest.cc b/shell/application_manager/application_manager_unittest.cc index d9f4bff..0c32de3 100644 --- a/shell/application_manager/application_manager_unittest.cc +++ b/shell/application_manager/application_manager_unittest.cc
@@ -11,10 +11,10 @@ #include "base/macros.h" #include "base/memory/scoped_vector.h" #include "base/message_loop/message_loop.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_delegate.h" #include "mojo/public/cpp/application/application_impl.h" #include "mojo/public/cpp/application/connect.h" +#include "mojo/public/cpp/application/service_provider_impl.h" #include "mojo/public/cpp/bindings/strong_binding.h" #include "mojo/public/interfaces/application/service_provider.mojom.h" #include "shell/application_manager/application_loader.h"
diff --git a/shell/context.cc b/shell/context.cc index 7e9e5dd..4abe127 100644 --- a/shell/context.cc +++ b/shell/context.cc
@@ -26,7 +26,6 @@ #include "mojo/edk/embedder/embedder.h" #include "mojo/edk/embedder/multiprocess_embedder.h" #include "mojo/edk/embedder/simple_platform_support.h" -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_delegate.h" #include "mojo/public/cpp/application/application_impl.h" #include "mojo/public/cpp/application/connect.h"
diff --git a/ui/ozone/platform/drm/mojo/drm_ipc_init_helper.cc b/ui/ozone/platform/drm/mojo/drm_ipc_init_helper.cc index aa1b6a9..ee97c98 100644 --- a/ui/ozone/platform/drm/mojo/drm_ipc_init_helper.cc +++ b/ui/ozone/platform/drm/mojo/drm_ipc_init_helper.cc
@@ -2,8 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/connect.h" +#include "mojo/public/cpp/application/service_provider_impl.h" #include "mojo/services/ozone_drm_gpu/interfaces/ozone_drm_gpu.mojom.h" #include "mojo/services/ozone_drm_host/interfaces/ozone_drm_host.mojom.h" #include "ui/ozone/platform/drm/mojo/drm_gpu_delegate.h"
diff --git a/ui/ozone/public/ipc_init_helper_mojo.h b/ui/ozone/public/ipc_init_helper_mojo.h index bc15fc6..c7754be 100644 --- a/ui/ozone/public/ipc_init_helper_mojo.h +++ b/ui/ozone/public/ipc_init_helper_mojo.h
@@ -5,8 +5,8 @@ #ifndef UI_OZONE_PUBLIC_IPC_INIT_HELPER_MOJO_H_ #define UI_OZONE_PUBLIC_IPC_INIT_HELPER_MOJO_H_ -#include "mojo/public/cpp/application/application_connection.h" #include "mojo/public/cpp/application/application_impl.h" +#include "mojo/public/cpp/application/service_provider_impl.h" #include "ui/ozone/public/ipc_init_helper_ozone.h" namespace ui {