Make gn check //examples/* pass R=sky@chromium.org Review URL: https://codereview.chromium.org/746303002
diff --git a/PRESUBMIT.py b/PRESUBMIT.py index da80e2a..8a57328 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py
@@ -444,6 +444,7 @@ # TODO(eseidel): Currently only these are known to pass, # once everything passes we can just call 'gn check' once without a filter! KNOWN_PASSING = [ + '//examples/*', '//mojo/aura/*', '//mojo/application/*', '//mojo/application_manager/*',
diff --git a/examples/apptest/BUILD.gn b/examples/apptest/BUILD.gn index bb8b5b9..6582af7 100644 --- a/examples/apptest/BUILD.gn +++ b/examples/apptest/BUILD.gn
@@ -28,7 +28,9 @@ ":bindings", "//mojo/public/c/system:for_shared_library", "//mojo/public/cpp/application:standalone", - "//mojo/public/cpp/utility" + "//mojo/public/cpp/bindings", + "//mojo/public/cpp/system", + "//mojo/public/cpp/utility", ] } @@ -50,6 +52,9 @@ "//mojo/public/c/system:for_shared_library", "//mojo/public/cpp/application:standalone", "//mojo/public/cpp/application:test_support_standalone", + "//mojo/public/cpp/bindings:callback", + "//mojo/public/cpp/environment", + "//mojo/public/cpp/system", ] datadeps = [ ":service", ]
diff --git a/examples/aura_demo/BUILD.gn b/examples/aura_demo/BUILD.gn index 90e73d0..657f441 100644 --- a/examples/aura_demo/BUILD.gn +++ b/examples/aura_demo/BUILD.gn
@@ -25,7 +25,9 @@ "//mojo/converters/geometry", "//mojo/aura", "//mojo/public/c/system:for_shared_library", + "//mojo/public/cpp/system", "//mojo/services/public/interfaces/geometry", + "//mojo/services/public/interfaces/native_viewport", "//mojo/services/public/cpp/view_manager", ] @@ -43,6 +45,7 @@ "//base", "//mojo/application", "//mojo/public/c/system:for_shared_library", + "//mojo/public/interfaces/application", "//mojo/services/public/cpp/view_manager", "//mojo/services/public/interfaces/view_manager", ]
diff --git a/examples/bitmap_uploader/BUILD.gn b/examples/bitmap_uploader/BUILD.gn index 4654fb8..86d9363 100644 --- a/examples/bitmap_uploader/BUILD.gn +++ b/examples/bitmap_uploader/BUILD.gn
@@ -20,11 +20,13 @@ "//mojo/public/cpp/bindings:bindings", "//mojo/public/gles2:for_shared_library", "//mojo/public/interfaces/application", + "//mojo/services/public/cpp/geometry", "//mojo/services/public/cpp/surfaces", "//mojo/services/public/cpp/view_manager", "//mojo/services/public/interfaces/geometry", "//mojo/services/public/interfaces/input_events:input_events", "//mojo/services/public/interfaces/surfaces:surface_id", "//mojo/services/public/interfaces/view_manager", + "//ui/gfx/geometry", ] }
diff --git a/examples/embedded_app/BUILD.gn b/examples/embedded_app/BUILD.gn index 12d19d0..2e02a72 100644 --- a/examples/embedded_app/BUILD.gn +++ b/examples/embedded_app/BUILD.gn
@@ -21,6 +21,7 @@ "//mojo/services/public/cpp/view_manager", "//mojo/services/public/interfaces/geometry", "//mojo/services/public/interfaces/navigation", + "//ui/events:events_base", "//ui/gfx/geometry", "//ui/gl", "//url",
diff --git a/examples/ganesh_app/BUILD.gn b/examples/ganesh_app/BUILD.gn index 3ec7117..4d885fb 100644 --- a/examples/ganesh_app/BUILD.gn +++ b/examples/ganesh_app/BUILD.gn
@@ -30,6 +30,8 @@ "//mojo/public/cpp/system", "//mojo/public/cpp/utility", "//mojo/public/gles2:for_shared_library", + "//mojo/public/interfaces/application", + "//mojo/services/public/cpp/geometry", "//mojo/services/public/cpp/surfaces", "//mojo/services/public/cpp/view_manager", "//mojo/services/public/interfaces/geometry",
diff --git a/examples/http_handler/BUILD.gn b/examples/http_handler/BUILD.gn index b38c3c9..970ef0f 100644 --- a/examples/http_handler/BUILD.gn +++ b/examples/http_handler/BUILD.gn
@@ -10,6 +10,7 @@ ] deps = [ + "//base", "//mojo/application", "//mojo/public/c/system:for_shared_library", "//mojo/public/cpp/bindings",
diff --git a/examples/nesting_app/BUILD.gn b/examples/nesting_app/BUILD.gn index 96ed196..6ce143b 100644 --- a/examples/nesting_app/BUILD.gn +++ b/examples/nesting_app/BUILD.gn
@@ -21,6 +21,7 @@ "//mojo/services/public/interfaces/geometry", "//mojo/services/public/interfaces/navigation", "//skia", + "//ui/events:events_base", "//ui/gfx/geometry", "//ui/gl", "//url",
diff --git a/examples/pdf_viewer/BUILD.gn b/examples/pdf_viewer/BUILD.gn index 82592ef..2f16799 100644 --- a/examples/pdf_viewer/BUILD.gn +++ b/examples/pdf_viewer/BUILD.gn
@@ -18,6 +18,7 @@ "//mojo/public/cpp/utility", "//mojo/services/public/cpp/view_manager", "//mojo/services/public/interfaces/content_handler", + "//mojo/services/public/interfaces/input_events", "//mojo/services/public/interfaces/network", "//third_party/pdfium", ]
diff --git a/examples/recursive_content_handler/BUILD.gn b/examples/recursive_content_handler/BUILD.gn index 2efeb0a..d4ff567 100644 --- a/examples/recursive_content_handler/BUILD.gn +++ b/examples/recursive_content_handler/BUILD.gn
@@ -10,6 +10,7 @@ ] deps = [ + "//base", "//mojo/application", "//mojo/application:content_handler", "//mojo/public/c/system:for_shared_library",
diff --git a/examples/sample_app/BUILD.gn b/examples/sample_app/BUILD.gn index e264297..597a71b 100644 --- a/examples/sample_app/BUILD.gn +++ b/examples/sample_app/BUILD.gn
@@ -18,6 +18,8 @@ "//mojo/public/c/system:for_shared_library", "//mojo/public/cpp/application:standalone", "//mojo/public/cpp/bindings", + "//mojo/public/cpp/environment", + "//mojo/public/cpp/system", "//mojo/public/cpp/utility", "//mojo/public/gles2:for_shared_library", "//mojo/services/public/interfaces/geometry",