Delete JSEchoTest.ShareEchoService -- it tests the wrong-way ServiceProvider (exposed_services). (exposed_services is going to be removed.) R=vardhan@google.com BUG=#762 Review URL: https://codereview.chromium.org/1964673002 .
diff --git a/services/js/echo_apptest.cc b/services/js/echo_apptest.cc index 6109d5c..9d7f343 100644 --- a/services/js/echo_apptest.cc +++ b/services/js/echo_apptest.cc
@@ -73,14 +73,5 @@ echo_service_->Quit(); } -// Verify that a JS app's ServiceProvider can request and provide services. -// This test exercises the same code paths as examples/js/share_echo.js. -TEST_F(JSEchoTest, ShareEchoService) { - bool returned_value = false; - EXPECT_TRUE(echo_service_->ShareEchoService(&returned_value)); - EXPECT_TRUE(returned_value); - echo_service_->Quit(); -} - } // namespace } // namespace js
diff --git a/services/js/test/echo.js b/services/js/test/echo.js index 1780864..871837c 100644 --- a/services/js/test/echo.js +++ b/services/js/test/echo.js
@@ -17,23 +17,6 @@ return Promise.resolve({value: s}); } - // This method is only used by the ShareEchoService test. - shareEchoService() { - var echoTargetURL = echoApp.url.replace("echo.js", "echo_target.js"); - var targetSP = echoApp.shell.connectToApplication(echoTargetURL); - // This Promise resolves after echo_target.js has called the echoString() - // method defined on the local EchoService implementation. For its part, - // the target application quits after one successful call to echoString(). - return new Promise(function(resolve) { - targetSP.provideService(EchoService, function() { - this.echoString = function(s) { - resolve({ok: true}); - return Promise.resolve({value: s}); - } - }); - }); - } - quit() { echoApp.quit(); }
diff --git a/services/js/test/echo_service.mojom b/services/js/test/echo_service.mojom index bb610f7..c085107 100644 --- a/services/js/test/echo_service.mojom +++ b/services/js/test/echo_service.mojom
@@ -8,12 +8,6 @@ interface EchoService { EchoString(string? value) => (string? value); - // Provide the EchoService to the echo_target.js - // application. The full URL for echo_target.js is - // computed relative to this application's URL. - // Return after echo_target has called EchoString(). - ShareEchoService() => (bool ok); - // Make it stop. Quit(); };