Remove ApplicationConnection::GetServiceProvider(). This is really only useful when there are wrong-way serivce providers. R=vardhan@google.com BUG=#762 Review URL: https://codereview.chromium.org/1966003002 .
diff --git a/mojo/public/cpp/application/application_connection.h b/mojo/public/cpp/application/application_connection.h index 9e6d39c..3507974 100644 --- a/mojo/public/cpp/application/application_connection.h +++ b/mojo/public/cpp/application/application_connection.h
@@ -62,11 +62,6 @@ // Returns the URL identifying the remote application on this connection. virtual const std::string& GetRemoteApplicationURL() = 0; - // Returns the raw proxy to the remote application's ServiceProvider - // interface. Most applications will just use ConnectToService() instead. - // Caller does not take ownership. - virtual ServiceProvider* GetServiceProvider() = 0; - private: virtual void SetServiceConnectorForName(ServiceConnector* service_connector, const std::string& name) = 0;
diff --git a/mojo/public/cpp/application/lib/service_registry.cc b/mojo/public/cpp/application/lib/service_registry.cc index dea138d..bbf685e 100644 --- a/mojo/public/cpp/application/lib/service_registry.cc +++ b/mojo/public/cpp/application/lib/service_registry.cc
@@ -56,10 +56,6 @@ return remote_url_; } -ServiceProvider* ServiceRegistry::GetServiceProvider() { - return remote_service_provider_.get(); -} - void ServiceRegistry::ConnectToService(const mojo::String& service_name, ScopedMessagePipeHandle client_handle) { service_connector_registry_.ConnectToService(this, service_name,
diff --git a/mojo/public/cpp/application/lib/service_registry.h b/mojo/public/cpp/application/lib/service_registry.h index 975fc21..f35c085 100644 --- a/mojo/public/cpp/application/lib/service_registry.h +++ b/mojo/public/cpp/application/lib/service_registry.h
@@ -37,7 +37,6 @@ const std::string& interface_name) override; const std::string& GetConnectionURL() override; const std::string& GetRemoteApplicationURL() override; - ServiceProvider* GetServiceProvider() override; void RemoveServiceConnectorForName(const std::string& interface_name);
diff --git a/services/log/log_impl_unittest.cc b/services/log/log_impl_unittest.cc index 1e402fa..2511972 100644 --- a/services/log/log_impl_unittest.cc +++ b/services/log/log_impl_unittest.cc
@@ -37,7 +37,6 @@ return kRemoteApplicationURL; } - ServiceProvider* GetServiceProvider() override { return nullptr; } void SetServiceConnectorForName(ServiceConnector* service_connector, const std::string& name) override {} };