Enables ASAN build and test for Dart After this change from koda@ [1], the Dart VM can run with the 'detect_stack_use_after_return' ASAN flag. [1] https://codereview.chromium.org/944783002/ BUG= R=jamesr@chromium.org Review URL: https://codereview.chromium.org/922903002
diff --git a/DEPS b/DEPS index 651ff17..ab58ade 100644 --- a/DEPS +++ b/DEPS
@@ -37,7 +37,7 @@ # Three lines of non-changing comments so that # the commit queue can handle CLs rolling Dart # and whatever else without interference from each other. - 'dart_revision': '43719', + 'dart_revision': '43955', # Three lines of non-changing comments so that # the commit queue can handle CLs rolling PDFium # and whatever else without interference from each other.
diff --git a/mojo/BUILD.gn b/mojo/BUILD.gn index 72b16ca..6ed78a3 100644 --- a/mojo/BUILD.gn +++ b/mojo/BUILD.gn
@@ -56,9 +56,11 @@ "//mojo/edk/js:tests", "//mojo/edk/system:tests", "//mojo/edk/test:public_tests", + "//mojo/dart/embedder/test:dart_unittests", "//mojo/services/view_manager/public/cpp/tests:mojo_view_manager_lib_unittests", "//mojo/tools:message_generator", "//services/clipboard:apptests", + "//services/dart:dart_apptests", "//services/http_server:apptests", "//services/js:js_apptests", "//services/js:js_services_unittests", @@ -73,11 +75,4 @@ if (use_prebuilt_network_service) { deps += [ "//mojo/public/tools:copy_network_service_apptests" ] } - - if (!is_asan) { - deps += [ - "//mojo/dart/embedder/test:dart_unittests", - "//services/dart:dart_apptests", - ] - } }
diff --git a/mojo/tools/data/apptests b/mojo/tools/data/apptests index 7a085a5..55ddc3b 100644 --- a/mojo/tools/data/apptests +++ b/mojo/tools/data/apptests
@@ -76,11 +76,6 @@ { "test": "mojo:reaper_apptests", }, - ] - -# TODO: get dart unittests working with asan. -if not config.sanitizer: - tests += [ { "test": "mojo:dart_apptests", },
diff --git a/mojo/tools/data/unittests b/mojo/tools/data/unittests index 6fe9f6e..8cb09dc 100644 --- a/mojo/tools/data/unittests +++ b/mojo/tools/data/unittests
@@ -80,8 +80,8 @@ }, ] -# TODO: get dart unittests working with asan and android. -if not config.sanitizer and config.target_os != config.OS_ANDROID: +# TODO: get dart unittests working with android. +if config.target_os != config.OS_ANDROID: tests += [ { "test": "dart_unittests",
diff --git a/services/BUILD.gn b/services/BUILD.gn index 33c6877..7abd919 100644 --- a/services/BUILD.gn +++ b/services/BUILD.gn
@@ -9,6 +9,7 @@ deps = [ "//services/clipboard", "//services/console", + "//services/dart", "//services/fake_surfaces", "//services/gles2:lib", "//services/http_server", @@ -29,10 +30,6 @@ deps += [ "//services/android:java_handler" ] } - if (!is_asan) { - deps += [ "//services/dart" ] - } - if (is_linux) { deps += [ "//services/python/content_handler" ] }